Fix invalid issue branch reference if not specified in template (go-gitea#22513)

brechtvl · jolheiser · commit f426ee9cbd28 · 2023-01-18T21:48:56.000-06:00
When an issue template does not contain a ref, it would end up with an
invalid `ref/heads/` value instead of having no branch referenced .
diff --git a/routers/web/repo/issue.go b/routers/web/repo/issue.go
@@ -786,7 +786,8 @@ func setTemplateIfExists(ctx *context.Context, ctxDataKey string, possibleFiles
 			}
 
 		}
-		if !strings.HasPrefix(template.Ref, "refs/") { // Assume that the ref intended is always a branch - for tags users should use refs/tags/<ref>
+
+		if template.Ref != "" && !strings.HasPrefix(template.Ref, "refs/") { // Assume that the ref intended is always a branch - for tags users should use refs/tags/<ref>
 			template.Ref = git.BranchPrefix + template.Ref
 		}
 		ctx.Data["HasSelectedLabel"] = len(labelIDs) > 0

Original file line number	Diff line number	Diff line change
`@@ -786,7 +786,8 @@ func setTemplateIfExists(ctx *context.Context, ctxDataKey string, possibleFiles`
`786`	`786`	`}`
`787`	`787`
`788`	`788`	`}`
`789`		`- if !strings.HasPrefix(template.Ref, "refs/") { // Assume that the ref intended is always a branch - for tags users should use refs/tags/<ref>`
	`789`	`+`
	`790`	`+ if template.Ref != "" && !strings.HasPrefix(template.Ref, "refs/") { // Assume that the ref intended is always a branch - for tags users should use refs/tags/<ref>`
`790`	`791`	`template.Ref = git.BranchPrefix + template.Ref`
`791`	`792`	`}`
`792`	`793`	`ctx.Data["HasSelectedLabel"] = len(labelIDs) > 0`