You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that PipeInput.read is wrong (it calls os.read(self._r), but os.read takes two arguments).
I've used PipeInput and never seen an issue with it, so I'm assuming that no code actually uses read, instead directly manipulating the fileno. Does this mean that Input subclasses have to have a real file number associated with them?
The text was updated successfully, but these errors were encountered:
I think you're correct that the read function is never used, so this looks like a bug indeed.
In any case, this has been changed on the 2.0 branch, the read function has been removed.
I don't recall the details at the moment, I'd need to look into it when I have a little more time.
I noticed that
PipeInput.read
is wrong (it callsos.read(self._r)
, butos.read
takes two arguments).I've used PipeInput and never seen an issue with it, so I'm assuming that no code actually uses
read
, instead directly manipulating thefileno
. Does this mean thatInput
subclasses have to have a real file number associated with them?The text was updated successfully, but these errors were encountered: