Skip to content

Is Input.read actually used? #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asmeurer opened this issue Jul 17, 2017 · 2 comments
Closed

Is Input.read actually used? #524

asmeurer opened this issue Jul 17, 2017 · 2 comments
Labels

Comments

@asmeurer
Copy link
Contributor

asmeurer commented Jul 17, 2017

I noticed that PipeInput.read is wrong (it calls os.read(self._r), but os.read takes two arguments).

I've used PipeInput and never seen an issue with it, so I'm assuming that no code actually uses read, instead directly manipulating the fileno. Does this mean that Input subclasses have to have a real file number associated with them?

@jonathanslenders
Copy link
Member

I think you're correct that the read function is never used, so this looks like a bug indeed.
In any case, this has been changed on the 2.0 branch, the read function has been removed.
I don't recall the details at the moment, I'd need to look into it when I have a little more time.

@jonathanslenders
Copy link
Member

Closing, because it's fixed in 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants