Skip to content

Commit 36d9349

Browse files
jhrcekmichaelpj
authored andcommitted
Fix -Wunused-packages in test utils (haskell#4004)
* Fix -Wunused-packages in test utils * stylish-haskell --------- Co-authored-by: Michael Peyton Jones <[email protected]>
1 parent 45f99ad commit 36d9349

File tree

3 files changed

+23
-28
lines changed

3 files changed

+23
-28
lines changed

hls-test-utils/hls-test-utils.cabal

+1-5
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,15 @@ library
3535
, aeson
3636
, async
3737
, base >=4.12 && <5
38-
, blaze-markup
3938
, bytestring
4039
, containers
4140
, data-default
4241
, directory
4342
, extra
4443
, filepath
4544
, ghcide == 2.6.0.0
46-
, hls-graph
4745
, hls-plugin-api == 2.6.0.0
4846
, lens
49-
, lsp ^>=2.3
5047
, lsp-test ^>=0.16
5148
, lsp-types ^>=2.1
5249
, tasty
@@ -56,9 +53,8 @@ library
5653
, tasty-rerun
5754
, temporary
5855
, text
59-
, unordered-containers
6056
, row-types
61-
ghc-options: -Wall
57+
ghc-options: -Wall -Wunused-packages
6258

6359
if flag(pedantic)
6460
ghc-options: -Werror

hls-test-utils/src/Test/Hls.hs

+12-13
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
1-
{-# LANGUAGE DataKinds #-}
2-
{-# LANGUAGE DisambiguateRecordFields #-}
3-
{-# LANGUAGE DuplicateRecordFields #-}
4-
{-# LANGUAGE GADTs #-}
5-
{-# LANGUAGE LambdaCase #-}
6-
{-# LANGUAGE NamedFieldPuns #-}
7-
{-# LANGUAGE OverloadedLists #-}
8-
{-# LANGUAGE OverloadedStrings #-}
9-
{-# LANGUAGE PolyKinds #-}
10-
{-# LANGUAGE RankNTypes #-}
11-
{-# LANGUAGE TypeApplications #-}
1+
{-# LANGUAGE DataKinds #-}
2+
{-# LANGUAGE DuplicateRecordFields #-}
3+
{-# LANGUAGE GADTs #-}
4+
{-# LANGUAGE LambdaCase #-}
5+
{-# LANGUAGE NamedFieldPuns #-}
6+
{-# LANGUAGE OverloadedLists #-}
7+
{-# LANGUAGE OverloadedStrings #-}
8+
{-# LANGUAGE PolyKinds #-}
9+
{-# LANGUAGE RankNTypes #-}
10+
{-# LANGUAGE TypeApplications #-}
1211
module Test.Hls
1312
( module Test.Tasty.HUnit,
1413
module Test.Tasty,
@@ -440,12 +439,12 @@ runSessionWithServerInTmpDir' plugins conf sessConf caps tree act = withLock loc
440439
| val /= "0" -> \action -> do
441440
(tempDir, _) <- newTempDir
442441
a <- action tempDir
443-
logWith recorder Debug $ LogNoCleanup
442+
logWith recorder Debug LogNoCleanup
444443
pure a
445444

446445
_ -> \action -> do
447446
a <- withTempDir action
448-
logWith recorder Debug $ LogCleanup
447+
logWith recorder Debug LogCleanup
449448
pure a
450449

451450
runTestInDir $ \tmpDir -> do

hls-test-utils/src/Test/Hls/Util.hs

+10-10
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
{-# LANGUAGE CPP #-}
2+
{-# LANGUAGE DataKinds #-}
23
{-# LANGUAGE DuplicateRecordFields #-}
34
{-# LANGUAGE FlexibleContexts #-}
45
{-# LANGUAGE GADTs #-}
56
{-# LANGUAGE MultiParamTypeClasses #-}
7+
{-# LANGUAGE OverloadedLabels #-}
68
{-# LANGUAGE OverloadedStrings #-}
9+
{-# LANGUAGE TypeApplications #-}
710
{-# LANGUAGE TypeOperators #-}
8-
{-# LANGUAGE OverloadedLabels #-}
9-
{-# LANGUAGE TypeApplications #-}
10-
{-# LANGUAGE DataKinds #-}
1111
module Test.Hls.Util
1212
( -- * Test Capabilities
1313
codeActionResolveCaps
@@ -54,22 +54,22 @@ where
5454

5555
import Control.Applicative.Combinators (skipManyTill, (<|>))
5656
import Control.Exception (catch, throwIO)
57-
import Control.Lens ((&), (?~), (^.), _Just, (.~))
57+
import Control.Lens (_Just, (&), (.~), (?~), (^.))
5858
import Control.Monad
5959
import Control.Monad.IO.Class
6060
import qualified Data.Aeson as A
6161
import Data.Bool (bool)
6262
import Data.Default
63-
import Data.Row
64-
import Data.Proxy
6563
import Data.List.Extra (find)
64+
import Data.Proxy
65+
import Data.Row
6666
import qualified Data.Set as Set
6767
import qualified Data.Text as T
6868
import Development.IDE (GhcVersion (..), ghcVersion)
69-
import qualified Language.LSP.Test as Test
70-
import Language.LSP.Protocol.Types
69+
import qualified Language.LSP.Protocol.Lens as L
7170
import Language.LSP.Protocol.Message
72-
import qualified Language.LSP.Protocol.Lens as L
71+
import Language.LSP.Protocol.Types
72+
import qualified Language.LSP.Test as Test
7373
import System.Directory
7474
import System.FilePath
7575
import System.Info.Extra (isMac, isWindows)
@@ -304,7 +304,7 @@ waitForDiagnosticsFromSourceWithTimeout timeout document source = do
304304
handleDiagnostic testId = do
305305
diagsNot <- Test.message SMethod_TextDocumentPublishDiagnostics
306306
let fileUri = diagsNot ^. L.params . L.uri
307-
( diags) = diagsNot ^. L.params . L.diagnostics
307+
diags = diagsNot ^. L.params . L.diagnostics
308308
res = filter matches diags
309309
if fileUri == document ^. L.uri && not (null res)
310310
then return res else handleMessages testId

0 commit comments

Comments
 (0)