Validate regular expressions in dynamic templates.

Today you would only get these errors at index time.

Relates elastic#24749

Author: jpountz

server/src/main/java/org/elasticsearch/index/mapper/DynamicTemplate.java

@@ -216,7 +216,24 @@ public static DynamicTemplate parse(String name, Map<String, Object> conf,
                 }
             }
         }
-        return new DynamicTemplate(name, pathMatch, pathUnmatch, match, unmatch, xcontentFieldType, MatchType.fromString(matchPattern), mapping);
+
+        final MatchType matchType = MatchType.fromString(matchPattern);
+
+        if (indexVersionCreated.onOrAfter(Version.V_6_3_0)) {
+            // Validate that the pattern
+            for (String regex : new String[] { pathMatch, match, pathUnmatch, unmatch }) {
+                if (regex == null) {
+                    continue;
+                }
+                try {
+                    matchType.matches(regex, "");
+                } catch (IllegalArgumentException e) {
+                    throw new IllegalArgumentException("Pattern [" + regex + "] of type [" + matchType + "] is invalid. Cannot create dynamic template [" + name + "].", e);
+                }
+            }
+        }
+
+        return new DynamicTemplate(name, pathMatch, pathUnmatch, match, unmatch, xcontentFieldType, matchType, mapping);
     }
 
     private final String name;

server/src/test/java/org/elasticsearch/index/mapper/DynamicTemplateTests.java

@@ -61,6 +61,19 @@ public void testParseUnknownMatchType() {
                 e.getMessage());
     }
 
+    public void testParseInvalidRegex() {
+        for (String param : new String[] { "path_match", "match", "path_unmatch", "unmatch" }) {System.out.println(param);
+            Map<String, Object> templateDef = new HashMap<>();
+            templateDef.put("match", "foo");
+            templateDef.put(param, "*a");
+            templateDef.put("match_pattern", "regex");
+            templateDef.put("mapping", Collections.singletonMap("store", true));
+            IllegalArgumentException e = expectThrows(IllegalArgumentException.class,
+                    () -> DynamicTemplate.parse("my_template", templateDef, Version.V_6_3_0));
+            assertEquals("Pattern [*a] of type [regex] is invalid. Cannot create dynamic template [my_template].", e.getMessage());
+        }
+    }
+
     public void testMatchAllTemplate() {
         Map<String, Object> templateDef = new HashMap<>();
         templateDef.put("match_mapping_type", "*");