net: really skip Windows PTR tests if we say we are skipping them

ianlancetaylor · jproberts · commit cb461ddfb9b3 · 2022-08-09T20:11:38.000-04:00
For golang#38111 Change-Id: I2651687367af68ee070ea91106f4bc18adab2762 Reviewed-on: https://go-review.googlesource.com/c/go/+/414634 Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
diff --git a/src/net/lookup_windows_test.go b/src/net/lookup_windows_test.go
@@ -156,7 +156,7 @@ func TestLookupLocalPTR(t *testing.T) {
 	}
 	expected, err := lookupPTR(addr.String())
 	if err != nil {
-		t.Logf("skipping failed lookup %s test: %s", addr.String(), err)
+		t.Skipf("skipping failed lookup %s test: %s", addr.String(), err)
 	}
 	sort.Strings(expected)
 	sort.Strings(names)
@@ -179,6 +179,7 @@ func TestLookupPTR(t *testing.T) {
 		expected, err := lookupPTR(addr)
 		if err != nil {
 			t.Logf("skipping failed lookup %s test: %s", addr, err)
+			continue
 		}
 		sort.Strings(expected)
 		sort.Strings(names)

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ func TestLookupLocalPTR(t *testing.T) {`
`156`	`156`	`}`
`157`	`157`	`expected, err := lookupPTR(addr.String())`
`158`	`158`	`if err != nil {`
`159`		`- t.Logf("skipping failed lookup %s test: %s", addr.String(), err)`
	`159`	`+ t.Skipf("skipping failed lookup %s test: %s", addr.String(), err)`
`160`	`160`	`}`
`161`	`161`	`sort.Strings(expected)`
`162`	`162`	`sort.Strings(names)`
`@@ -179,6 +179,7 @@ func TestLookupPTR(t *testing.T) {`
`179`	`179`	`expected, err := lookupPTR(addr)`
`180`	`180`	`if err != nil {`
`181`	`181`	`t.Logf("skipping failed lookup %s test: %s", addr, err)`
	`182`	`+ continue`
`182`	`183`	`}`
`183`	`184`	`sort.Strings(expected)`
`184`	`185`	`sort.Strings(names)`