Skip to content

Commit 7fb0e87

Browse files
committed
fix(selenium): fix verbose mode with await
- the selenium types are wrong here. getCapabilities is async. - added -v to the jquery tests to the path is hit
1 parent 7c476de commit 7fb0e87

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

.github/workflows/jquery.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,4 @@ jobs:
3737

3838
- name: Run jQuery tests
3939
working-directory: test/jquery
40-
run: npm install && npm run test:browser
40+
run: npm install && npm run test:browser -- -v

selenium/createDriver.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,9 @@ export default async function createDriver( { browserName, headless, url, verbos
8181
.build();
8282

8383
if ( verbose ) {
84-
const driverCapabilities = driver.getCapabilities();
84+
85+
// The types are currently wrong here. await is required.
86+
const driverCapabilities = await driver.getCapabilities();
8587
const name = driverCapabilities.getBrowserName();
8688
const version = driverCapabilities.getBrowserVersion();
8789
console.log( `\nDriver created for ${ name } ${ version }` );

0 commit comments

Comments
 (0)