[refactor] move Date.new helper to utils

we should update these to faster native parts with JRuby >= 9.2

Author: kares

src/java/arjdbc/mssql/MSSQLRubyJdbcConnection.java

@@ -45,6 +45,7 @@
 import java.util.List;
 import java.util.Map;
 
+import arjdbc.util.DateTimeUtils;
 import org.joda.time.DateTime;
 import org.joda.time.DateTimeZone;
 import org.jruby.Ruby;
@@ -370,14 +371,7 @@ protected IRubyObject dateToRuby(ThreadContext context, Ruby runtime, ResultSet
 
         if (value == null) return context.nil;
 
-        // Using Date.civil(year, month, day) so calendars get set correctly
-        final IRubyObject[] args = {
-            runtime.newFixnum(value.getYear() + 1900),
-            runtime.newFixnum(value.getMonth() + 1),
-            runtime.newFixnum(value.getDate())
-        };
-
-        return runtime.getClass("Date").callMethod(context, "civil", args);
+        return DateTimeUtils.newDate(context, value);
     }
 
     /**

src/java/arjdbc/util/DateTimeUtils.java

@@ -31,6 +31,7 @@
 import org.joda.time.Chronology;
 import org.joda.time.DateTime;
 import org.joda.time.DateTimeZone;
+import org.joda.time.chrono.GJChronology;
 import org.joda.time.chrono.ISOChronology;
 import org.jruby.Ruby;
 import org.jruby.RubyFloat;
@@ -263,6 +264,18 @@ public static IRubyObject newDate(final ThreadContext context, final Date date,
         return newDate(context, year, month, day, ISOChronology.getInstance(zone));
     }
 
+    @SuppressWarnings("deprecation")
+    public static IRubyObject newDate(final ThreadContext context, final Date date) {
+        final int year = date.getYear() + 1900;
+        final int month = date.getMonth() + 1;
+        final int day = date.getDate();
+
+        // TODO update to using fast-path without dynamic call (after >= 9.2)
+        final Ruby runtime = context.runtime;
+        final IRubyObject[] args = { runtime.newFixnum(year), runtime.newFixnum(month), runtime.newFixnum(day) };
+        return runtime.getClass("Date").callMethod(context, "civil", args);
+    }
+
     // @Deprecated
     public static Timestamp convertToTimestamp(final RubyFloat value) {
         final Timestamp timestamp = new Timestamp(value.getLongValue() * 1000); // millis
@@ -557,7 +570,7 @@ else if ( e1 == 'B' && str.charAt(start + 1) == 'C' ) {
     }
 
     private static IRubyObject newDate(final ThreadContext context, final int year, final int month, final int day,
-                                       final ISOChronology chronology) {
+                                       final Chronology chronology) {
         // NOTE: JRuby really needs a native date.rb until than its a bit costly going from ...
         // java.sql.Date -> allocating a DateTime proxy, help a bit by shooting at the internals
         //