Skip to content

Commit 5d570ed

Browse files
Merge pull request pybamm-team#2822 from pybamm-team/issue-2788-last-state
Fix use of last-state as starting-solution in Simulation.solve()
2 parents c78bed2 + ac47b03 commit 5d570ed

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
- Improved `model.latexify()` to have a cleaner and more readable output ([#2764](https://github.com/pybamm-team/PyBaMM/pull/2764))
1616
- Fixed electrolyte conservation in the case of concentration-dependent transference number ([#2758](https://github.com/pybamm-team/PyBaMM/pull/2758))
1717
- Fixed `plot_voltage_components` so that the sum of overpotentials is now equal to the voltage ([#2740](https://github.com/pybamm-team/PyBaMM/pull/2740))
18+
- Fixed use of last_state as starting_solution in Simulation.solve() ([#2822](https://github.com/pybamm-team/PyBaMM/pull/2822))
1819

1920
## Optimizations
2021

pybamm/simulation.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,7 @@ def solve(
652652
cycle_sum_vars,
653653
cycle_first_state,
654654
) = pybamm.make_cycle_solution(
655-
starting_solution.steps,
655+
[starting_solution],
656656
esoh_solver=esoh_solver,
657657
save_this_cycle=True,
658658
)

0 commit comments

Comments
 (0)