Skip to content

Commit ae6636a

Browse files
committed
Squashed 'release-tools/' changes from 31aa44d..335339f
kubernetes-csi/csi-release-tools@335339f0 Merge kubernetes-csi/csi-release-tools#187 from mauriciopoppe/remove-eol-windows-versions kubernetes-csi/csi-release-tools@890b87a2 Merge kubernetes-csi/csi-release-tools#188 from pwschuurman/update-release-notes-docs kubernetes-csi/csi-release-tools@274bc9ba Update Sidecar Release Process documentation to reference latest syntax for release-notes tool kubernetes-csi/csi-release-tools@87b6c372 Merge kubernetes-csi/csi-release-tools#185 from Garima-Negi/fix-OWNERS-files kubernetes-csi/csi-release-tools@f1de2c66 Fix OWNERS file - squashed commits kubernetes-csi/csi-release-tools@59ae38b7 Remove EOL windows versions from BUILD_PLATFORMS kubernetes-csi/csi-release-tools@5d664712 Merge kubernetes-csi/csi-release-tools#186 from humblec/sp kubernetes-csi/csi-release-tools@d066f1ba Correct prow.sh typo and make codespell linter pass kubernetes-csi/csi-release-tools@762e22d0 Merge kubernetes-csi/csi-release-tools#184 from pohly/image-publishing-troubleshooting kubernetes-csi/csi-release-tools@81e26c3f SIDECAR_RELEASE_PROCESS.md: add troubleshooting for image publishing git-subtree-dir: release-tools git-subtree-split: 335339f
1 parent fc416f0 commit ae6636a

File tree

3 files changed

+47
-20
lines changed

3 files changed

+47
-20
lines changed

KUBERNETES_CSI_OWNERS_ALIASES

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,7 @@ aliases:
3131

3232
# This documents who previously contributed to Kubernetes-CSI
3333
# as approver.
34-
emeritus_approver:
34+
emeritus_approvers:
3535
- lpabon
3636
- sbezverk
3737
- vladimirvivien
38-
39-
# This documents who previously contributed to Kubernetes-CSI
40-
# as reviewer.
41-
emeritus_reviewer:
42-
- lpabon
43-
- saad-ali
44-
- sbezverk
45-
- vladimirvivien

SIDECAR_RELEASE_PROCESS.md

Lines changed: 44 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,26 +46,38 @@ naming convention `<hostpath-deployment-version>-on-<kubernetes-version>`.
4646
## Release Process
4747
1. Identify all issues and ongoing PRs that should go into the release, and
4848
drive them to resolution.
49-
1. Download v2.8+ [K8s release notes
50-
generator](https://github.com/kubernetes/release/tree/HEAD/cmd/release-notes)
49+
1. Download the latest version of the
50+
[K8s release notes generator](https://github.com/kubernetes/release/tree/HEAD/cmd/release-notes)
51+
1. Create a
52+
[Github personal access token](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token)
53+
with `repo:public_repo` access
5154
1. Generate release notes for the release. Replace arguments with the relevant
52-
information.
55+
information.
5356
* Clean up old cached information (also needed if you are generating release
5457
notes for multiple repos)
5558
```bash
5659
rm -rf /tmp/k8s-repo
5760
```
5861
* For new minor releases on master:
5962
```bash
60-
GITHUB_TOKEN=<token> release-notes --discover=mergebase-to-latest
61-
--github-org=kubernetes-csi --github-repo=external-provisioner
62-
--required-author="" --output out.md
63+
GITHUB_TOKEN=<token> release-notes \
64+
--discover=mergebase-to-latest \
65+
--org=kubernetes-csi \
66+
--repo=external-provisioner \
67+
--required-author="" \
68+
--markdown-links \
69+
--output out.md
6370
```
6471
* For new patch releases on a release branch:
6572
```bash
66-
GITHUB_TOKEN=<token> release-notes --discover=patch-to-latest --branch=release-1.1
67-
--github-org=kubernetes-csi --github-repo=external-provisioner
68-
--required-author="" --output out.md
73+
GITHUB_TOKEN=<token> release-notes \
74+
--discover=patch-to-latest \
75+
--branch=release-1.1 \
76+
--org=kubernetes-csi \
77+
--repo=external-provisioner \
78+
--required-author="" \
79+
--markdown-links \
80+
--output out.md
6981
```
7082
1. Compare the generated output to the new commits for the release to check if
7183
any notable change missed a release note.
@@ -100,6 +112,29 @@ naming convention `<hostpath-deployment-version>-on-<kubernetes-version>`.
100112
and [k/k
101113
in-tree](https://github.com/kubernetes/kubernetes/tree/HEAD/test/e2e/testing-manifests/storage-csi/hostpath/hostpath)
102114

115+
### Troubleshooting
116+
117+
#### Image build jobs
118+
119+
The following jobs are triggered after tagging to produce the corresponding
120+
image(s):
121+
https://k8s-testgrid.appspot.com/sig-storage-image-build
122+
123+
Clicking on a failed build job opens that job in https://prow.k8s.io. Next to
124+
the job title is a rerun icon (circle with arrow). Clicking it opens a popup
125+
with a "rerun" button that maintainers with enough permissions can use. If in
126+
doubt, ask someone on #sig-release to rerun the job.
127+
128+
Another way to rerun a job is to search for it in https://prow.k8s.io and click
129+
the rerun icon in the resulting job list:
130+
https://prow.k8s.io/?job=canary-csi-test-push-images
131+
132+
#### Verify images
133+
134+
Canary and staged images can be viewed at https://console.cloud.google.com/gcr/images/k8s-staging-sig-storage
135+
136+
Promoted images can be viewed at https://console.cloud.google.com/gcr/images/k8s-artifacts-prod/us/sig-storage
137+
103138
## Adding support for a new Kubernetes release
104139

105140
1. Add the new release to `k8s_versions` in

prow.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ version_to_git () {
7878
# the list of windows versions was matched from:
7979
# - https://hub.docker.com/_/microsoft-windows-nanoserver
8080
# - https://hub.docker.com/_/microsoft-windows-servercore
81-
configvar CSI_PROW_BUILD_PLATFORMS "linux amd64 amd64; linux ppc64le ppc64le -ppc64le; linux s390x s390x -s390x; linux arm arm -arm; linux arm64 arm64 -arm64; linux arm arm/v7 -armv7; windows amd64 amd64 .exe nanoserver:1809 servercore:ltsc2019; windows amd64 amd64 .exe nanoserver:1909 servercore:1909; windows amd64 amd64 .exe nanoserver:2004 servercore:2004; windows amd64 amd64 .exe nanoserver:20H2 servercore:20H2; windows amd64 amd64 .exe nanoserver:ltsc2022 servercore:ltsc2022" "Go target platforms (= GOOS + GOARCH) and file suffix of the resulting binaries"
81+
configvar CSI_PROW_BUILD_PLATFORMS "linux amd64 amd64; linux ppc64le ppc64le -ppc64le; linux s390x s390x -s390x; linux arm arm -arm; linux arm64 arm64 -arm64; linux arm arm/v7 -armv7; windows amd64 amd64 .exe nanoserver:1809 servercore:ltsc2019; windows amd64 amd64 .exe nanoserver:20H2 servercore:20H2; windows amd64 amd64 .exe nanoserver:ltsc2022 servercore:ltsc2022" "Go target platforms (= GOOS + GOARCH) and file suffix of the resulting binaries"
8282

8383
# If we have a vendor directory, then use it. We must be careful to only
8484
# use this for "make" invocations inside the project's repo itself because
@@ -737,7 +737,7 @@ install_csi_driver () {
737737
fi
738738
}
739739

740-
# Installs all nessesary snapshotter CRDs
740+
# Installs all necessary snapshotter CRDs
741741
install_snapshot_crds() {
742742
# Wait until volumesnapshot CRDs are in place.
743743
CRD_BASE_DIR="https://raw.githubusercontent.com/kubernetes-csi/external-snapshotter/${CSI_SNAPSHOTTER_VERSION}/client/config/crd"

0 commit comments

Comments
 (0)