Review feedback

Author: Bart Koelman

Diff for: JsonApiDotNetCore.sln.DotSettings

@@ -629,6 +629,7 @@ $left$ = $right$;</s:String>
 	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=B3D9EE6B4EC62A4F961EB15F9ADEC2C6/ReplacePattern/@EntryValue">$collection$.IsNullOrEmpty()</s:String>
 	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=B3D9EE6B4EC62A4F961EB15F9ADEC2C6/SearchPattern/@EntryValue">$collection$ == null || !$collection$.Any()</s:String>
 	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=B3D9EE6B4EC62A4F961EB15F9ADEC2C6/Severity/@EntryValue">WARNING</s:String>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=Accurize/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=appsettings/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Assignee/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Contoso/@EntryIndexedValue">True</s:Boolean>

Diff for: docs/usage/reading/filtering.md

@@ -90,7 +90,6 @@ Which returns only customers that have at least one unpaid order.
 _since v5.0_
 
 Use the `isType` filter function to perform a type check on a derived type. You can pass a nested filter, where the derived fields are accessible.
-The first parameter can be used to perform the type check on a to-one relationship path.
 
 Only return men:
 ```http
@@ -102,6 +101,8 @@ Only return men with beards:
 GET /humans?filter=isType(,men,equals(hasBeard,'true')) HTTP/1.1
 ```
 
+The first parameter of `isType` can be used to perform the type check on a to-one relationship path.
+
 Only return people whose best friend is a man with children:
 ```http
 GET /humans?filter=isType(bestFriend,men,has(children)) HTTP/1.1

Diff for: docs/usage/resources/inheritance.md

@@ -185,7 +185,6 @@ public override SortExpression OnApplySort(SortExpression? existingSort)
 ### Filtering
 
 Use the `isType` filter function to perform a type check on a derived type. You can pass a nested filter, where the derived fields are accessible.
-The first parameter can be used to perform the type check on a to-one relationship path.
 
 Only return men:
 ```http
@@ -197,6 +196,8 @@ Only return men with beards:
 GET /humans?filter=isType(,men,equals(hasBeard,'true')) HTTP/1.1
 ```
 
+The first parameter of `isType` can be used to perform the type check on a to-one relationship path.
+
 Only return people whose best friend is a man with children:
 ```http
 GET /humans?filter=isType(bestFriend,men,has(children)) HTTP/1.1
@@ -287,7 +288,7 @@ Resource definitions provide a better solution, see below.
 
 ### Resource definitions
 
-In contract to the request pipeline, JsonApiDotNetCore always executes the resource definition that matches the *stored* type.
+In contrast to the request pipeline, JsonApiDotNetCore always executes the resource definition that matches the *stored* type.
 This enables to implement business logic in a central place, irrespective of which endpoint was used or whether base types were used in relationships.
 
 To delegate logic for base types to their matching resource type, you can build a chain of resource definitions. And because you'll always get the

Diff for: src/JsonApiDotNetCore/Services/JsonApiResourceService.cs

@@ -202,11 +202,11 @@ private async Task RetrieveResourceCountForNonPrimaryEndpointAsync(TId id, HasMa
         TResource resourceFromRequest = resource;
         _resourceChangeTracker.SetRequestAttributeValues(resourceFromRequest);
 
-        await RefreshResourceTypesInHierarchyToAssignInRelationshipsAsync(resourceFromRequest, cancellationToken);
+        await AccurizeResourceTypesInHierarchyToAssignInRelationshipsAsync(resourceFromRequest, cancellationToken);
 
         Type resourceClrType = resourceFromRequest.GetClrType();
         TResource resourceForDatabase = await _repositoryAccessor.GetForCreateAsync<TResource, TId>(resourceClrType, resourceFromRequest.Id, cancellationToken);
-        PromoteJsonApiRequest(resourceForDatabase);
+        AccurizeJsonApiRequest(resourceForDatabase);
 
         _resourceChangeTracker.SetInitiallyStoredAttributeValues(resourceForDatabase);
 
@@ -249,7 +249,7 @@ protected virtual async Task InitializeResourceAsync(TResource resourceForDataba
         await _resourceDefinitionAccessor.OnPrepareWriteAsync(resourceForDatabase, WriteOperationKind.CreateResource, cancellationToken);
     }
 
-    private async Task RefreshResourceTypesInHierarchyToAssignInRelationshipsAsync(TResource primaryResource, CancellationToken cancellationToken)
+    private async Task AccurizeResourceTypesInHierarchyToAssignInRelationshipsAsync(TResource primaryResource, CancellationToken cancellationToken)
     {
         await ValidateResourcesToAssignInRelationshipsExistWithRefreshAsync(primaryResource, true, cancellationToken);
     }
@@ -360,7 +360,7 @@ public virtual async Task AddToToManyRelationshipAsync(TId leftId, string relati
             // The left resource may be stored as a derived type. We fetch it, so we'll know the stored type, which
             // enables to invoke IResourceDefinition<TResource> with TResource being the stored resource type.
             resourceFromDatabase ??= await GetPrimaryResourceForUpdateAsync(leftId, cancellationToken);
-            PromoteJsonApiRequest(resourceFromDatabase);
+            AccurizeJsonApiRequest(resourceFromDatabase);
         }
 
         ISet<IIdentifiable> effectiveRightResourceIds = rightResourceIds;
@@ -453,10 +453,10 @@ private async Task<TResource> GetForHasManyUpdateAsync(HasManyAttribute hasManyR
         TResource resourceFromRequest = resource;
         _resourceChangeTracker.SetRequestAttributeValues(resourceFromRequest);
 
-        await RefreshResourceTypesInHierarchyToAssignInRelationshipsAsync(resourceFromRequest, cancellationToken);
+        await AccurizeResourceTypesInHierarchyToAssignInRelationshipsAsync(resourceFromRequest, cancellationToken);
 
         TResource resourceFromDatabase = await GetPrimaryResourceForUpdateAsync(id, cancellationToken);
-        PromoteJsonApiRequest(resourceFromDatabase);
+        AccurizeJsonApiRequest(resourceFromDatabase);
 
         _resourceChangeTracker.SetInitiallyStoredAttributeValues(resourceFromDatabase);
 
@@ -503,7 +503,7 @@ public virtual async Task SetRelationshipAsync(TId leftId, string relationshipNa
             : rightValue;
 
         TResource resourceFromDatabase = await GetPrimaryResourceForUpdateAsync(leftId, cancellationToken);
-        PromoteJsonApiRequest(resourceFromDatabase);
+        AccurizeJsonApiRequest(resourceFromDatabase);
 
         await _resourceDefinitionAccessor.OnPrepareWriteAsync(resourceFromDatabase, WriteOperationKind.SetRelationship, cancellationToken);
 
@@ -537,7 +537,7 @@ public virtual async Task DeleteAsync(TId id, CancellationToken cancellationToke
             // The resource to delete may be stored as a derived type. We fetch it, so we'll know the stored type, which
             // enables to invoke IResourceDefinition<TResource> with TResource being the stored resource type.
             resourceFromDatabase = await GetPrimaryResourceForUpdateAsync(id, cancellationToken);
-            PromoteJsonApiRequest(resourceFromDatabase);
+            AccurizeJsonApiRequest(resourceFromDatabase);
         }
 
         try
@@ -571,7 +571,7 @@ public virtual async Task RemoveFromToManyRelationshipAsync(TId leftId, string r
         var hasManyRelationship = (HasManyAttribute)_request.Relationship;
 
         TResource resourceFromDatabase = await GetForHasManyUpdateAsync(hasManyRelationship, leftId, rightResourceIds, cancellationToken);
-        PromoteJsonApiRequest(resourceFromDatabase);
+        AccurizeJsonApiRequest(resourceFromDatabase);
 
         object? rightValue = await AssertRightResourcesExistAsync(rightResourceIds, cancellationToken);
         ISet<IIdentifiable> effectiveRightResourceIds = ((IEnumerable<IIdentifiable>)rightValue!).ToHashSet(IdentifiableComparer.Instance);
@@ -610,7 +610,7 @@ protected async Task<TResource> GetPrimaryResourceForUpdateAsync(TId id, Cancell
         return resource;
     }
 
-    private void PromoteJsonApiRequest(TResource resourceFromDatabase)
+    private void AccurizeJsonApiRequest(TResource resourceFromDatabase)
     {
         // When using resource inheritance, the stored left-side resource may be more derived than what this endpoint assumes.
         // In that case, we promote data in IJsonApiRequest to better represent what is going on.