Additional self-review round

Author: maurei

Diff for: JsonApiDotNetCore.sln.DotSettings

@@ -15,9 +15,6 @@ JsonApiDotNetCore.ArgumentGuard.NotNull($EXPR$, $NAME$);</s:String>
 	<s:Int64 x:Key="/Default/CodeEditing/NullCheckPatterns/PatternTypeNamesToPriority/=JetBrains_002EReSharper_002EFeature_002EServices_002ECSharp_002ENullChecking_002ETraceAssertPattern/@EntryIndexedValue">50</s:Int64>
 	<s:Boolean x:Key="/Default/CodeInspection/CodeAnnotations/PropagateAnnotations/@EntryValue">False</s:Boolean>
 	<s:Boolean x:Key="/Default/CodeInspection/ExcludedFiles/FileMasksToSkip/=swagger_002Ejson/@EntryIndexedValue">True</s:Boolean>
-	
-	
-	
 	<s:String x:Key="/Default/CodeInspection/GeneratedCode/GeneratedFileMasks/=swagger_002Ejson/@EntryIndexedValue">swagger.json</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/AnalysisEnabled/@EntryValue">SOLUTION</s:String>
 	<s:Boolean x:Key="/Default/CodeInspection/Highlighting/IdentifierHighlightingEnabled/@EntryValue">True</s:Boolean>

Diff for: src/JsonApiDotNetCore.OpenApi.Client/ApiException.cs

@@ -16,9 +16,7 @@ internal class ApiException : Exception
     public IReadOnlyDictionary<string, IEnumerable<string>> Headers { get; }
 
     public ApiException(string message, int statusCode, string? response, IReadOnlyDictionary<string, IEnumerable<string>> headers, Exception innerException)
-        : base(
-            message + "\n\nStatus: " + statusCode + "\nResponse: \n" +
-            (response == null ? "(null)" : response[..(response.Length >= 512 ? 512 : response.Length)]), innerException)
+        : base($"{message}\n\nStatus: {statusCode}\nResponse: \n{response ?? "(null)"}", innerException)
     {
         StatusCode = statusCode;
         Response = response;

Diff for: src/JsonApiDotNetCore.OpenApi/StringExtensions.cs

@@ -4,10 +4,10 @@ namespace JsonApiDotNetCore.OpenApi;
 
 internal static class StringExtensions
 {
-    private static readonly Regex Pattern = new("(?:^|-|_| +)(.)", RegexOptions.Compiled);
+    private static readonly Regex PatternForPascalCaseConversion = new("(?:^|-|_| +)(.)", RegexOptions.Compiled);
 
     public static string ToPascalCase(this string source)
     {
-        return Pattern.Replace(source, match => match.Groups[1].Value.ToUpper());
+        return PatternForPascalCaseConversion.Replace(source, match => match.Groups[1].Value.ToUpper());
     }
 }

Diff for: test/OpenApiTests/JsonElementExtensions.cs

@@ -35,15 +35,17 @@ public static ReferenceSchemaIdContainer ShouldBeReferenceSchemaId(this JsonElem
         string referenceSchemaId = jsonElementValue.Split('/').Last();
         referenceSchemaId.Should().Be(value);
 
-        return new ReferenceSchemaIdContainer
-        {
-            ReferenceSchemaId = value
-        };
+        return new ReferenceSchemaIdContainer(value);
     }
 
     public sealed class ReferenceSchemaIdContainer
     {
-        internal string ReferenceSchemaId { get; init; } = null!;
+        public string ReferenceSchemaId { get; }
+
+        public ReferenceSchemaIdContainer(string referenceSchemaId)
+        {
+            ReferenceSchemaId = referenceSchemaId;
+        }
     }
 
     public sealed class JsonElementAssertions : JsonElementAssertions<JsonElementAssertions>

Diff for: test/OpenApiTests/OpenApiTestSuite.cs

@@ -10,18 +10,18 @@ public abstract class OpenApiTestSuite<TStartup, TDbContext> : IClassFixture<Ope
     where TDbContext : DbContext
 {
     private readonly OpenApiTestContext<TStartup, TDbContext> _testContext;
-    private readonly bool _shouldWriteDocumentToDisk;
+    private readonly bool _isFirstTestRunInTestSuite;
 
     protected OpenApiTestSuite(OpenApiTestContext<TStartup, TDbContext> testContext)
     {
         _testContext = testContext;
-        _shouldWriteDocumentToDisk = !testContext.LazyDocument.IsValueCreated;
+        _isFirstTestRunInTestSuite = !testContext.LazyDocument.IsValueCreated;
     }
 
     protected void UseController<TController>()
         where TController : ControllerBase
     {
-        if (!_testContext.LazyDocument.IsValueCreated)
+        if (_isFirstTestRunInTestSuite)
         {
             _testContext.UseController<TController>();
         }
@@ -31,7 +31,7 @@ protected async Task<JsonElement> GetDocumentAsync()
     {
         JsonElement document = await _testContext.LazyDocument.Value;
 
-        if (_shouldWriteDocumentToDisk)
+        if (_isFirstTestRunInTestSuite)
         {
             await WriteSwaggerDocumentToFileAsync(document);
         }
@@ -51,6 +51,7 @@ private static string GetTestSuitePath()
     {
         string pathToSolutionTestDirectory = Path.Combine(Environment.CurrentDirectory, "../../../../");
         pathToSolutionTestDirectory = Path.GetFullPath(pathToSolutionTestDirectory);
+
         string pathToCurrentNamespaceRelativeToTestDirectory = Path.Combine(typeof(TStartup).Namespace!.Split('.'));
 
         return Path.Join(pathToSolutionTestDirectory, pathToCurrentNamespaceRelativeToTestDirectory);