Resharper: Use collection expression

Author: bkoelman

JsonApiDotNetCore.sln.DotSettings

@@ -93,6 +93,7 @@ JsonApiDotNetCore.ArgumentGuard.NotNull($EXPR$);</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UseNegatedPatternInIsExpression/@EntryIndexedValue">SUGGESTION</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UseNegatedPatternMatching/@EntryIndexedValue">SUGGESTION</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=VirtualMemberNeverOverridden_002ELocal/@EntryIndexedValue">WARNING</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/UseCollectionExpression/ConvertEmptyCollection/@EntryValue">SUGGESTION</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeCleanup/Profiles/=JADNC_0020Full_0020Cleanup/@EntryIndexedValue">&lt;?xml version="1.0" encoding="utf-16"?&gt;&lt;Profile name="JADNC Full Cleanup"&gt;&lt;XMLReformatCode&gt;True&lt;/XMLReformatCode&gt;&lt;CSCodeStyleAttributes ArrangeTypeAccessModifier="True" ArrangeTypeMemberAccessModifier="True" SortModifiers="True" RemoveRedundantParentheses="True" AddMissingParentheses="True" ArrangeBraces="True" ArrangeAttributes="True" ArrangeArgumentsStyle="True" ArrangeCodeBodyStyle="True" ArrangeVarStyle="True" ArrangeTrailingCommas="True" ArrangeObjectCreation="True" ArrangeDefaultValue="True" ArrangeNamespaces="True" ArrangeNullCheckingPattern="True" /&gt;&lt;CssAlphabetizeProperties&gt;True&lt;/CssAlphabetizeProperties&gt;&lt;JsInsertSemicolon&gt;True&lt;/JsInsertSemicolon&gt;&lt;FormatAttributeQuoteDescriptor&gt;True&lt;/FormatAttributeQuoteDescriptor&gt;&lt;CorrectVariableKindsDescriptor&gt;True&lt;/CorrectVariableKindsDescriptor&gt;&lt;VariablesToInnerScopesDescriptor&gt;True&lt;/VariablesToInnerScopesDescriptor&gt;&lt;StringToTemplatesDescriptor&gt;True&lt;/StringToTemplatesDescriptor&gt;&lt;JsReformatCode&gt;True&lt;/JsReformatCode&gt;&lt;JsFormatDocComments&gt;True&lt;/JsFormatDocComments&gt;&lt;RemoveRedundantQualifiersTs&gt;True&lt;/RemoveRedundantQualifiersTs&gt;&lt;OptimizeImportsTs&gt;True&lt;/OptimizeImportsTs&gt;&lt;OptimizeReferenceCommentsTs&gt;True&lt;/OptimizeReferenceCommentsTs&gt;&lt;PublicModifierStyleTs&gt;True&lt;/PublicModifierStyleTs&gt;&lt;ExplicitAnyTs&gt;True&lt;/ExplicitAnyTs&gt;&lt;TypeAnnotationStyleTs&gt;True&lt;/TypeAnnotationStyleTs&gt;&lt;RelativePathStyleTs&gt;True&lt;/RelativePathStyleTs&gt;&lt;AsInsteadOfCastTs&gt;True&lt;/AsInsteadOfCastTs&gt;&lt;HtmlReformatCode&gt;True&lt;/HtmlReformatCode&gt;&lt;AspOptimizeRegisterDirectives&gt;True&lt;/AspOptimizeRegisterDirectives&gt;&lt;RemoveCodeRedundancies&gt;True&lt;/RemoveCodeRedundancies&gt;&lt;CSUseAutoProperty&gt;True&lt;/CSUseAutoProperty&gt;&lt;CSMakeFieldReadonly&gt;True&lt;/CSMakeFieldReadonly&gt;&lt;CSMakeAutoPropertyGetOnly&gt;True&lt;/CSMakeAutoPropertyGetOnly&gt;&lt;CSArrangeQualifiers&gt;True&lt;/CSArrangeQualifiers&gt;&lt;CSFixBuiltinTypeReferences&gt;True&lt;/CSFixBuiltinTypeReferences&gt;&lt;CssReformatCode&gt;True&lt;/CssReformatCode&gt;&lt;CSOptimizeUsings&gt;&lt;OptimizeUsings&gt;True&lt;/OptimizeUsings&gt;&lt;/CSOptimizeUsings&gt;&lt;CSShortenReferences&gt;True&lt;/CSShortenReferences&gt;&lt;CSReformatCode&gt;True&lt;/CSReformatCode&gt;&lt;CSharpFormatDocComments&gt;True&lt;/CSharpFormatDocComments&gt;&lt;CSReorderTypeMembers&gt;True&lt;/CSReorderTypeMembers&gt;&lt;XAMLCollapseEmptyTags&gt;False&lt;/XAMLCollapseEmptyTags&gt;&lt;CSReformatInactiveBranches&gt;True&lt;/CSReformatInactiveBranches&gt;&lt;/Profile&gt;</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeCleanup/SilentCleanupProfile/@EntryValue">JADNC Full Cleanup</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpCodeStyle/BRACES_FOR_FOR/@EntryValue">Required</s:String>
@@ -125,6 +126,7 @@ JsonApiDotNetCore.ArgumentGuard.NotNull($EXPR$);</s:String>
 	<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/KEEP_EXISTING_SWITCH_EXPRESSION_ARRANGEMENT/@EntryValue">False</s:Boolean>
 	<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/KEEP_USER_LINEBREAKS/@EntryValue">False</s:Boolean>
 	<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/LINE_FEED_AT_FILE_END/@EntryValue">True</s:Boolean>
+	<s:Int64 x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/MAX_ARRAY_INITIALIZER_ELEMENTS_ON_LINE/@EntryValue">1</s:Int64>
 	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/PLACE_ACCESSOR_ATTRIBUTE_ON_SAME_LINE_EX/@EntryValue">NEVER</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/PLACE_ACCESSORHOLDER_ATTRIBUTE_ON_SAME_LINE_EX/@EntryValue">NEVER</s:String>
 	<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/PLACE_CONSTRUCTOR_INITIALIZER_ON_SAME_LINE/@EntryValue">False</s:Boolean>
@@ -145,6 +147,7 @@ JsonApiDotNetCore.ArgumentGuard.NotNull($EXPR$);</s:String>
 	<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/WRAP_BEFORE_LINQ_EXPRESSION/@EntryValue">True</s:Boolean>
 	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/WRAP_FOR_STMT_HEADER_STYLE/@EntryValue">WRAP_IF_LONG</s:String>
 	<s:Int64 x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/WRAP_LIMIT/@EntryValue">160</s:Int64>
+	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/WRAP_LIST_PATTERN/@EntryValue">CHOP_IF_LONG</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/WRAP_MULTIPLE_DECLARATION_STYLE/@EntryValue">WRAP_IF_LONG</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/WRAP_MULTIPLE_TYPE_PARAMEER_CONSTRAINTS_STYLE/@EntryValue">CHOP_ALWAYS</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/WRAP_OBJECT_AND_COLLECTION_INITIALIZER_STYLE/@EntryValue">CHOP_ALWAYS</s:String>

WarningSeverities.DotSettings

@@ -240,6 +240,7 @@
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UseAwaitUsing/@EntryIndexedValue">WARNING</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UseCancellationTokenForIAsyncEnumerable/@EntryIndexedValue">WARNING</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UseCollectionCountProperty/@EntryIndexedValue">WARNING</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UseCollectionExpression/@EntryIndexedValue">WARNING</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UseFormatSpecifierInFormatString/@EntryIndexedValue">WARNING</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UseFormatSpecifierInInterpolation/@EntryIndexedValue">WARNING</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UseIndexFromEndExpression/@EntryIndexedValue">WARNING</s:String>
@@ -264,4 +265,5 @@
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=VirtualMemberNeverOverridden_002ELocal/@EntryIndexedValue">WARNING</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=WithExpressionInsteadOfInitializer/@EntryIndexedValue">WARNING</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=WrongIndentSize/@EntryIndexedValue">WARNING</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/UseCollectionExpression/ConvertEmptyCollection/@EntryValue">WARNING</s:String>
 </wpf:ResourceDictionary>

src/Examples/DapperExample/Data/RotatingList.cs

@@ -4,7 +4,7 @@ internal abstract class RotatingList
 {
     public static RotatingList<T> Create<T>(int count, Func<int, T> createElement)
     {
-        List<T> elements = new();
+        List<T> elements = [];
 
         for (int index = 0; index < count; index++)
         {

src/Examples/DapperExample/Definitions/TodoItemDefinition.cs

@@ -29,11 +29,10 @@ public override SortExpression OnApplySort(SortExpression? existingSort)
 
     private SortExpression GetDefaultSortOrder()
     {
-        return CreateSortExpressionFromLambda(new PropertySortOrder
-        {
+        return CreateSortExpressionFromLambda([
             (todoItem => todoItem.Priority, ListSortDirection.Ascending),
             (todoItem => todoItem.LastModifiedAt, ListSortDirection.Descending)
-        });
+        ]);
     }
 
     public override Task OnWritingAsync(TodoItem resource, WriteOperationKind writeOperation, CancellationToken cancellationToken)

src/Examples/DapperExample/Repositories/DapperFacade.cs

@@ -38,7 +38,7 @@ public IReadOnlyCollection<CommandDefinition> BuildSqlCommandsForOneToOneRelatio
     {
         ArgumentGuard.NotNull(changeDetector);
 
-        List<CommandDefinition> sqlCommands = new();
+        List<CommandDefinition> sqlCommands = [];
 
         foreach ((HasOneAttribute relationship, (object? currentRightId, object newRightId)) in changeDetector.GetOneToOneRelationshipsChangedToNotNull())
         {
@@ -81,7 +81,7 @@ public IReadOnlyCollection<CommandDefinition> BuildSqlCommandsForChangedRelation
     {
         ArgumentGuard.NotNull(changeDetector);
 
-        List<CommandDefinition> sqlCommands = new();
+        List<CommandDefinition> sqlCommands = [];
 
         foreach ((HasOneAttribute hasOneRelationship, (object? currentRightId, object? newRightId)) in changeDetector
             .GetChangedToOneRelationshipsWithForeignKeyAtRightSide())

src/Examples/DapperExample/Repositories/ResourceChangeDetector.cs

@@ -15,11 +15,11 @@ internal sealed class ResourceChangeDetector
     private readonly CollectionConverter _collectionConverter = new();
     private readonly IDataModelService _dataModelService;
 
-    private Dictionary<string, object?> _currentColumnValues = new();
-    private Dictionary<string, object?> _newColumnValues = new();
+    private Dictionary<string, object?> _currentColumnValues = [];
+    private Dictionary<string, object?> _newColumnValues = [];
 
-    private Dictionary<RelationshipAttribute, ISet<IIdentifiable>> _currentRightResourcesByRelationship = new();
-    private Dictionary<RelationshipAttribute, ISet<IIdentifiable>> _newRightResourcesByRelationship = new();
+    private Dictionary<RelationshipAttribute, ISet<IIdentifiable>> _currentRightResourcesByRelationship = [];
+    private Dictionary<RelationshipAttribute, ISet<IIdentifiable>> _newRightResourcesByRelationship = [];
 
     public ResourceType ResourceType { get; }
 
@@ -52,7 +52,7 @@ public void CaptureNewValues(IIdentifiable resource)
 
     private Dictionary<string, object?> CaptureColumnValues(IIdentifiable resource)
     {
-        Dictionary<string, object?> columnValues = new();
+        Dictionary<string, object?> columnValues = [];
 
         foreach ((string columnName, ResourceFieldAttribute? _) in _dataModelService.GetColumnMappings(ResourceType))
         {
@@ -64,7 +64,7 @@ public void CaptureNewValues(IIdentifiable resource)
 
     private Dictionary<RelationshipAttribute, ISet<IIdentifiable>> CaptureRightResourcesByRelationship(IIdentifiable resource)
     {
-        Dictionary<RelationshipAttribute, ISet<IIdentifiable>> relationshipValues = new();
+        Dictionary<RelationshipAttribute, ISet<IIdentifiable>> relationshipValues = [];
 
         foreach (RelationshipAttribute relationship in ResourceType.Relationships)
         {
@@ -107,7 +107,7 @@ public void AssertIsNotClearingAnyRequiredToOneRelationships(string resourceName
 
     public IReadOnlyDictionary<HasOneAttribute, (object? currentRightId, object newRightId)> GetOneToOneRelationshipsChangedToNotNull()
     {
-        Dictionary<HasOneAttribute, (object? currentRightId, object newRightId)> changes = new();
+        Dictionary<HasOneAttribute, (object? currentRightId, object newRightId)> changes = [];
 
         foreach ((RelationshipAttribute relationship, ISet<IIdentifiable> newRightResources) in _newRightResourcesByRelationship)
         {
@@ -135,7 +135,7 @@ public void AssertIsNotClearingAnyRequiredToOneRelationships(string resourceName
 
     public IReadOnlyDictionary<string, object?> GetChangedColumnValues()
     {
-        Dictionary<string, object?> changes = new();
+        Dictionary<string, object?> changes = [];
 
         foreach ((string columnName, object? newColumnValue) in _newColumnValues)
         {
@@ -152,7 +152,7 @@ public void AssertIsNotClearingAnyRequiredToOneRelationships(string resourceName
 
     public IReadOnlyDictionary<HasOneAttribute, (object? currentRightId, object? newRightId)> GetChangedToOneRelationshipsWithForeignKeyAtRightSide()
     {
-        Dictionary<HasOneAttribute, (object? currentRightId, object? newRightId)> changes = new();
+        Dictionary<HasOneAttribute, (object? currentRightId, object? newRightId)> changes = [];
 
         foreach ((RelationshipAttribute relationship, ISet<IIdentifiable> newRightResources) in _newRightResourcesByRelationship)
         {
@@ -183,7 +183,7 @@ public void AssertIsNotClearingAnyRequiredToOneRelationships(string resourceName
 
     public IReadOnlyDictionary<HasManyAttribute, (ISet<object> currentRightIds, ISet<object> newRightIds)> GetChangedToManyRelationships()
     {
-        Dictionary<HasManyAttribute, (ISet<object> currentRightIds, ISet<object> newRightIds)> changes = new();
+        Dictionary<HasManyAttribute, (ISet<object> currentRightIds, ISet<object> newRightIds)> changes = [];
 
         foreach ((RelationshipAttribute relationship, ISet<IIdentifiable> newRightResources) in _newRightResourcesByRelationship)
         {
@@ -194,7 +194,7 @@ public void AssertIsNotClearingAnyRequiredToOneRelationships(string resourceName
                 HashSet<object> currentRightIds =
                     _currentRightResourcesByRelationship.TryGetValue(hasManyRelationship, out ISet<IIdentifiable>? currentRightResources)
                         ? currentRightResources.Select(resource => resource.GetTypedId()).ToHashSet()
-                        : new HashSet<object>();
+                        : [];
 
                 if (!currentRightIds.SetEquals(newRightIds))
                 {

src/Examples/DapperExample/Repositories/ResultSetMapper.cs

@@ -12,20 +12,20 @@ namespace DapperExample.Repositories;
 internal sealed class ResultSetMapper<TResource, TId>
     where TResource : class, IIdentifiable<TId>
 {
-    private readonly List<Type> _joinObjectTypes = new();
+    private readonly List<Type> _joinObjectTypes = [];
 
     // For each object type, we keep a map of ID/instance pairs.
     // Note we don't do full bidirectional relationship fix-up; this just avoids duplicate instances.
-    private readonly Dictionary<Type, Dictionary<object, object>> _resourceByTypeCache = new();
+    private readonly Dictionary<Type, Dictionary<object, object>> _resourceByTypeCache = [];
 
     // Optimization to avoid unneeded calls to expensive Activator.CreateInstance() method, which is needed multiple times per row.
-    private readonly Dictionary<Type, object?> _defaultValueByTypeCache = new();
+    private readonly Dictionary<Type, object?> _defaultValueByTypeCache = [];
 
     // Used to determine where in the tree of included relationships a join object belongs to.
     private readonly Dictionary<IncludeElementExpression, int> _includeElementToJoinObjectArrayIndexLookup = new(ReferenceEqualityComparer.Instance);
 
     // The return value of the mapping process.
-    private readonly List<TResource> _primaryResourcesInOrder = new();
+    private readonly List<TResource> _primaryResourcesInOrder = [];
 
     // The included relationships for which an INNER/LEFT JOIN statement was produced, which we're mapping.
     private readonly IncludeExpression _include;
@@ -36,15 +36,15 @@ public ResultSetMapper(IncludeExpression? include)
     {
         _include = include ?? IncludeExpression.Empty;
         _joinObjectTypes.Add(typeof(TResource));
-        _resourceByTypeCache[typeof(TResource)] = new Dictionary<object, object>();
+        _resourceByTypeCache[typeof(TResource)] = [];
 
         var walker = new IncludeElementWalker(_include);
         int index = 1;
 
         foreach (IncludeElementExpression includeElement in walker.BreadthFirstEnumerate())
         {
             _joinObjectTypes.Add(includeElement.Relationship.RightType.ClrType);
-            _resourceByTypeCache[includeElement.Relationship.RightType.ClrType] = new Dictionary<object, object>();
+            _resourceByTypeCache[includeElement.Relationship.RightType.ClrType] = [];
             _includeElementToJoinObjectArrayIndexLookup[includeElement] = index;
 
             index++;

src/Examples/DapperExample/Repositories/SqlCaptureStore.cs

@@ -9,7 +9,7 @@ namespace DapperExample.Repositories;
 [PublicAPI]
 public sealed class SqlCaptureStore
 {
-    private readonly List<SqlCommand> _sqlCommands = new();
+    private readonly List<SqlCommand> _sqlCommands = [];
 
     public IReadOnlyList<SqlCommand> SqlCommands => _sqlCommands;
 

src/Examples/DapperExample/TranslationToSql/Builders/InsertStatementBuilder.cs

@@ -28,7 +28,7 @@ public InsertNode Build(ResourceType resourceType, IReadOnlyDictionary<string, o
 
     private List<ColumnAssignmentNode> GetColumnAssignments(IReadOnlyDictionary<string, object?> columnsToSet, TableNode table)
     {
-        List<ColumnAssignmentNode> assignments = new();
+        List<ColumnAssignmentNode> assignments = [];
         ColumnNode idColumn = table.GetIdColumn(table.Alias);
 
         foreach ((string columnName, object? columnValue) in columnsToSet)