test(acceptance): failing test for related attr filter

Author: jaredcnance

src/JsonApiDotNetCoreExample/Models/Person.cs

@@ -1,5 +1,4 @@
 using System.Collections.Generic;
-using JsonApiDotNetCore.Internal;
 using JsonApiDotNetCore.Models;
 using JsonApiDotNetCore.Services;
 

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/AttributeFilterTests.cs

@@ -2,19 +2,17 @@
 using System.Net.Http;
 using System.Threading.Tasks;
 using DotNetCoreDocs;
-using DotNetCoreDocs.Models;
 using DotNetCoreDocs.Writers;
 using JsonApiDotNetCoreExample;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.TestHost;
-using Newtonsoft.Json;
 using Xunit;
-using JsonApiDotNetCore.Internal;
 using JsonApiDotNetCoreExample.Data;
 using Bogus;
 using JsonApiDotNetCoreExample.Models;
 using JsonApiDotNetCore.Serialization;
 using System.Linq;
+using Person = JsonApiDotNetCoreExample.Models.Person;
 
 namespace JsonApiDotNetCoreExampleTests.Acceptance.Spec
 {
@@ -23,13 +21,18 @@ public class AttributeFilterTests
     {
         private DocsFixture<Startup, JsonDocWriter> _fixture;
         private Faker<TodoItem> _todoItemFaker;
-        
+        private readonly Faker<Person> _personFaker;
+
         public AttributeFilterTests(DocsFixture<Startup, JsonDocWriter> fixture)
         {
             _fixture = fixture;
             _todoItemFaker = new Faker<TodoItem>()
                 .RuleFor(t => t.Description, f => f.Lorem.Sentence())
                 .RuleFor(t => t.Ordinal, f => f.Random.Number());
+
+            _personFaker = new Faker<Person>()
+                .RuleFor(p => p.FirstName, f => f.Name.FirstName())
+                .RuleFor(p => p.LastName, f => f.Name.LastName());
         }
 
         [Fact]
@@ -63,5 +66,39 @@ public async Task Can_Filter_On_Guid_Properties()
             Assert.Equal(todoItem.Id, todoItemResponse.Id);
             Assert.Equal(todoItem.GuidProperty, todoItemResponse.GuidProperty);
         }
+
+
+        [Fact]
+        public async Task Can_Filter_On_Related_Attrs()
+        {
+            // arrange
+            var context = _fixture.GetService<AppDbContext>();
+            var person = _personFaker.Generate();
+            var todoItem = _todoItemFaker.Generate();
+            todoItem.Owner = person;
+            context.TodoItems.Add(todoItem);
+            await context.SaveChangesAsync();
+            
+            var builder = new WebHostBuilder()
+                .UseStartup<Startup>();
+            var httpMethod = new HttpMethod("GET");
+            var route = $"/api/v1/todo-items?include[owner]&filter[owner.first-name]={person.FirstName}";
+            var server = new TestServer(builder);
+            var client = server.CreateClient();
+            var request = new HttpRequestMessage(httpMethod, route);
+
+            // act
+            var response = await client.SendAsync(request);
+            var body = await response.Content.ReadAsStringAsync();
+            var deserializedBody = _fixture
+                .GetService<IJsonApiDeSerializer>()
+                .DeserializeList<TodoItem>(body);
+
+            // assert
+            Assert.Equal(HttpStatusCode.OK, response.StatusCode);
+            Assert.NotEmpty(deserializedBody);
+            foreach(var item in  deserializedBody)
+                Assert.Equal(person.FirstName, item.Owner.FirstName);
+        }
     }
 }