Skip to content

Commit 9720ea0

Browse files
author
Bart Koelman
committed
Corrected terminology: The attributes from the incoming request, not the requested set of attribute.
1 parent 5b637d2 commit 9720ea0

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

src/JsonApiDotNetCore/Resources/IResourceChangeTracker.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public interface IResourceChangeTracker<in TResource>
1515
/// <summary>
1616
/// Sets the (subset of) exposed resource attributes from the POST or PATCH request.
1717
/// </summary>
18-
void SetRequestedAttributeValues(TResource resource);
18+
void SetRequestAttributeValues(TResource resource);
1919

2020
/// <summary>
2121
/// Sets the exposed resource attributes as stored in database, after applying the POST or PATCH operation.

src/JsonApiDotNetCore/Resources/ResourceChangeTracker.cs

+6-6
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public sealed class ResourceChangeTracker<TResource> : IResourceChangeTracker<TR
1616
private readonly ITargetedFields _targetedFields;
1717

1818
private IDictionary<string, string> _initiallyStoredAttributeValues;
19-
private IDictionary<string, string> _requestedAttributeValues;
19+
private IDictionary<string, string> _requestAttributeValues;
2020
private IDictionary<string, string> _finallyStoredAttributeValues;
2121

2222
public ResourceChangeTracker(IJsonApiOptions options, IResourceContextProvider resourceContextProvider, ITargetedFields targetedFields)
@@ -40,11 +40,11 @@ public void SetInitiallyStoredAttributeValues(TResource resource)
4040
}
4141

4242
/// <inheritdoc />
43-
public void SetRequestedAttributeValues(TResource resource)
43+
public void SetRequestAttributeValues(TResource resource)
4444
{
4545
ArgumentGuard.NotNull(resource, nameof(resource));
4646

47-
_requestedAttributeValues = CreateAttributeDictionary(resource, _targetedFields.Attributes);
47+
_requestAttributeValues = CreateAttributeDictionary(resource, _targetedFields.Attributes);
4848
}
4949

5050
/// <inheritdoc />
@@ -75,12 +75,12 @@ public bool HasImplicitChanges()
7575
{
7676
foreach (string key in _initiallyStoredAttributeValues.Keys)
7777
{
78-
if (_requestedAttributeValues.ContainsKey(key))
78+
if (_requestAttributeValues.ContainsKey(key))
7979
{
80-
string requestedValue = _requestedAttributeValues[key];
80+
string requestValue = _requestAttributeValues[key];
8181
string actualValue = _finallyStoredAttributeValues[key];
8282

83-
if (requestedValue != actualValue)
83+
if (requestValue != actualValue)
8484
{
8585
return true;
8686
}

src/JsonApiDotNetCore/Services/JsonApiResourceService.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ public virtual async Task<TResource> CreateAsync(TResource resource, Cancellatio
169169
using IDisposable _ = CodeTimingSessionManager.Current.Measure("Service - Create resource");
170170

171171
TResource resourceFromRequest = resource;
172-
_resourceChangeTracker.SetRequestedAttributeValues(resourceFromRequest);
172+
_resourceChangeTracker.SetRequestAttributeValues(resourceFromRequest);
173173

174174
TResource resourceForDatabase = await _repositoryAccessor.GetForCreateAsync<TResource, TId>(resource.Id, cancellationToken);
175175

@@ -334,7 +334,7 @@ public virtual async Task<TResource> UpdateAsync(TId id, TResource resource, Can
334334
using IDisposable _ = CodeTimingSessionManager.Current.Measure("Service - Update resource");
335335

336336
TResource resourceFromRequest = resource;
337-
_resourceChangeTracker.SetRequestedAttributeValues(resourceFromRequest);
337+
_resourceChangeTracker.SetRequestAttributeValues(resourceFromRequest);
338338

339339
TResource resourceFromDatabase = await GetPrimaryResourceForUpdateAsync(id, cancellationToken);
340340

test/TestBuildingBlocks/NeverSameResourceChangeTracker.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public void SetInitiallyStoredAttributeValues(TResource resource)
1212
{
1313
}
1414

15-
public void SetRequestedAttributeValues(TResource resource)
15+
public void SetRequestAttributeValues(TResource resource)
1616
{
1717
}
1818

0 commit comments

Comments
 (0)