Process review feedback

Author: maurei

Diff for: JsonApiDotNetCore.sln.DotSettings

@@ -15,6 +15,9 @@ JsonApiDotNetCore.ArgumentGuard.NotNull($EXPR$, $NAME$);</s:String>
 	<s:Int64 x:Key="/Default/CodeEditing/NullCheckPatterns/PatternTypeNamesToPriority/=JetBrains_002EReSharper_002EFeature_002EServices_002ECSharp_002ENullChecking_002ETraceAssertPattern/@EntryIndexedValue">50</s:Int64>
 	<s:Boolean x:Key="/Default/CodeInspection/CodeAnnotations/PropagateAnnotations/@EntryValue">False</s:Boolean>
 	<s:Boolean x:Key="/Default/CodeInspection/ExcludedFiles/FileMasksToSkip/=swagger_002Ejson/@EntryIndexedValue">True</s:Boolean>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=B693DE14_002DBB28_002D496F_002DAB39_002DB4E674ABCA80_002Fd_003ANamingConventions_002Fd_003ACamelCase_002Ff_003Aswagger_002Ejson/@EntryIndexedValue">ExplicitlyExcluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=B693DE14_002DBB28_002D496F_002DAB39_002DB4E674ABCA80_002Fd_003ANamingConventions_002Fd_003AKebabCase_002Ff_003Aswagger_002Ejson/@EntryIndexedValue">ExplicitlyExcluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=B693DE14_002DBB28_002D496F_002DAB39_002DB4E674ABCA80_002Fd_003ANamingConventions_002Fd_003APascalCase_002Ff_003Aswagger_002Ejson/@EntryIndexedValue">ExplicitlyExcluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/AnalysisEnabled/@EntryValue">SOLUTION</s:String>
 	<s:Boolean x:Key="/Default/CodeInspection/Highlighting/IdentifierHighlightingEnabled/@EntryValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/CodeInspection/Highlighting/IncludeWarningsInSwea/@EntryValue">True</s:Boolean>

Diff for: src/JsonApiDotNetCore.OpenApi.Client/ApiException.cs

@@ -1,44 +1,45 @@
 using JetBrains.Annotations;
 
 // We cannot rely on generating ApiException as soon as we are generating multiple clients, see https://github.com/RicoSuter/NSwag/issues/2839#issuecomment-776647377.
-// Instead, we take the generated code as is and use it for the various clients.
-#nullable disable
-// @formatter:off
-// ReSharper disable All
-namespace JsonApiDotNetCore.OpenApi.Client.Exceptions
+// Instead, we configure NSwag to point to the exception below in the generated code.
+
+// ReSharper disable once CheckNamespace
+namespace JsonApiDotNetCore.OpenApi.Client.Exceptions;
+
+[UsedImplicitly(ImplicitUseTargetFlags.Members)]
+internal class ApiException : Exception
 {
-    [UsedImplicitly(ImplicitUseTargetFlags.Members)]
-    internal class ApiException : Exception
-    {
-        public int StatusCode { get; }
+    public int StatusCode { get; }
+
+    public string? Response { get; }
 
-        public string Response { get; }
+    public IReadOnlyDictionary<string, IEnumerable<string>> Headers { get; }
 
-        public IReadOnlyDictionary<string, IEnumerable<string>> Headers { get; }
+    public ApiException(string message, int statusCode, string? response, IReadOnlyDictionary<string, IEnumerable<string>> headers, Exception innerException)
+        : base(
+            message + "\n\nStatus: " + statusCode + "\nResponse: \n" +
+            (response == null ? "(null)" : response[..(response.Length >= 512 ? 512 : response.Length)]), innerException)
+    {
+        StatusCode = statusCode;
+        Response = response;
+        Headers = headers;
+    }
 
-        public ApiException(string message, int statusCode, string response, IReadOnlyDictionary<string, IEnumerable<string>> headers, Exception innerException)
-            : base(
-                message + "\n\nStatus: " + statusCode + "\nResponse: \n" +
-                (response == null ? "(null)" : response.Substring(0, response.Length >= 512 ? 512 : response.Length)), innerException)
-        {
-            StatusCode = statusCode;
-            Response = response;
-            Headers = headers;
-        }
+    public override string ToString()
+    {
+        return $"HTTP Response: \n\n{Response}\n\n{base.ToString()}";
+    }
+}
 
-        public override string ToString()
-        {
-            return $"HTTP Response: \n\n{Response}\n\n{base.ToString()}";
-        }}
+[UsedImplicitly(ImplicitUseTargetFlags.Members)]
+internal sealed class ApiException<TResult> : ApiException
+{
+    public TResult Result { get; }
 
-    internal sealed class ApiException<TResult> : ApiException
+    public ApiException(string message, int statusCode, string? response, IReadOnlyDictionary<string, IEnumerable<string>> headers, TResult result,
+        Exception innerException)
+        : base(message, statusCode, response, headers, innerException)
     {
-        public TResult Result { get; }
-
-        public ApiException(string message, int statusCode, string response, IReadOnlyDictionary<string, IEnumerable<string>> headers, TResult result,
-            Exception innerException)
-            : base(message, statusCode, response, headers, innerException)
-        {
-            Result = result;
-        }}
+        Result = result;
+    }
 }

Diff for: src/JsonApiDotNetCore.OpenApi/JsonApiOperationIdSelector.cs

@@ -112,7 +112,7 @@ private string ApplyTemplate(string operationIdTemplate, ResourceType resourceTy
             throw new UnreachableCodeException();
         }
 
-        string method = endpoint.HttpMethod!.ToLowerInvariant();
+        string method = endpoint.HttpMethod.ToLowerInvariant();
         string relationshipName = operationIdTemplate.Contains("[RelationshipName]") ? endpoint.RelativePath.Split("/").Last() : string.Empty;
 
         // @formatter:wrap_chained_method_calls chop_always

Diff for: src/JsonApiDotNetCore.OpenApi/ServiceCollectionExtensions.cs

@@ -41,7 +41,6 @@ private static void AddCustomApiExplorer(IServiceCollection services, IMvcCoreBu
             var apiDescriptionProviders = provider.GetRequiredService<IEnumerable<IApiDescriptionProvider>>();
 
             JsonApiActionDescriptorCollectionProvider descriptorCollectionProviderWrapper = new(controllerResourceMapping, actionDescriptorCollectionProvider);
-
             return new ApiDescriptionGroupCollectionProvider(descriptorCollectionProviderWrapper, apiDescriptionProviders);
         });
 

Diff for: src/JsonApiDotNetCore.OpenApi/StringExtensions.cs

@@ -4,8 +4,10 @@ namespace JsonApiDotNetCore.OpenApi;
 
 internal static class StringExtensions
 {
+    private static readonly Regex Pattern = new("(?:^|-|_| +)(.)", RegexOptions.Compiled);
+
     public static string Pascalize(this string source)
     {
-        return Regex.Replace(source, "(?:^|-|_| +)(.)", match => match.Groups[1].Value.ToUpper());
+        return Pattern.Replace(source, match => match.Groups[1].Value.ToUpper());
     }
 }

Diff for: src/JsonApiDotNetCore.OpenApi/SwaggerComponents/NullableReferenceSchemaGenerator.cs

@@ -10,8 +10,8 @@ internal sealed class NullableReferenceSchemaGenerator
     private readonly NullableReferenceSchemaStrategy _nullableReferenceStrategy =
         Enum.Parse<NullableReferenceSchemaStrategy>(NullableReferenceSchemaStrategy.Implicit.ToString());
 
-    private readonly string _nullableSchemaReferenceId;
     private readonly ISchemaRepositoryAccessor _schemaRepositoryAccessor;
+    private readonly string _nullableSchemaReferenceId;
 
     private OpenApiSchema? _referenceSchemaForExplicitNullValue;