Skip to content

Update variable / class naming conventions #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
maurei opened this issue Oct 10, 2019 · 0 comments
Closed
4 tasks done

Update variable / class naming conventions #572

maurei opened this issue Oct 10, 2019 · 0 comments

Comments

@maurei
Copy link
Member

maurei commented Oct 10, 2019 •
edited by wisepotato
Loading

Proposal is to normalise several class names and property names.

Related to #317

  • RelationshipAttribute.DependentType and .PrincipicalType is not adequate. Replace with something like LeftType vs RightType or HostType vs RelatedType.
  • rename ContextEntity to ResourceContext, so that it is consistent with ResourceDefinition and ResourceHooks
  • ContextEntity.EntityType --> .ResourceType and current .ResourceType --> .ResourceDefinitionType.
  • EntityResourceService --> DefaultResourceService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maurei