Skip to content

Review logging #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bart-degreed opened this issue Feb 14, 2020 · 2 comments · Fixed by #714
Closed

Review logging #689

bart-degreed opened this issue Feb 14, 2020 · 2 comments · Fixed by #714

Comments

@bart-degreed
Copy link
Contributor

Description

Now that we have the right logging dependencies in place, we should review when, what and at which level logging occurs within JADNC.

Official guidance on logging levels: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/logging/?view=aspnetcore-2.2#log-level

I'm thinking of:

  • Do not log events at error level which cannot be solved by us, but are functional errors that do not require investigation. Like resource-not-found, invalid-attribute-name, resource-already-exists, input validation errors etc.
  • Basic trace/debug logging of JSON request/response, along with qualified URL
  • Log query string parsing results, maybe

Additions are welcome!

@maurei
Copy link
Member

maurei commented Feb 19, 2020

It might be a good idea to check out another big framework and see it is approached there. But indeed, there is a lot of room for improvement here!

@bart-degreed
Copy link
Contributor Author

Sure. Do you have any in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants