Skip to content

README badges have incorrect numbers #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
handrews opened this issue Oct 28, 2017 · 6 comments
Closed

README badges have incorrect numbers #460

handrews opened this issue Oct 28, 2017 · 6 comments
Assignees

Comments

@handrews
Copy link
Contributor

There are currently two issues and two PRs with "Status: Review Needed" but the README badge says 36. That's rather annoying.

Also, the link for the first badge is a bit different than the others (open issues rather than just the label, which hits both issues and PRs).

I couldn't find documentation for these on Waffle and wasn't sure where else to look. @Relequestual where did you get these exactly?

@Relequestual
Copy link
Member

UGH. I think the link is somehow broken.
I MAY have got notified of this fact, flagged it to do, and got lost in emails.
The badges are using https://shields.io, which has an interface to waffle.

It looks like shields.io now supports number of open issues by label (and PRs by label), which wasn't previously a thing.

It makes sense to dissassociate from waffle and just use the new direct route. I don't think any of us used or wanted to use any of waffles features.

@Relequestual
Copy link
Member

Sorry about the AGE of this issue... =[

@handrews
Copy link
Contributor Author

@Relequestual no worries, it's not the most urgent thing in the world! :-)

I agree on just using shields.io directly and skipping waffle as we're not really using it.

@handrews
Copy link
Contributor Author

@Relequestual I can't make heads or tails of what's going on at shields.io. I tried to customize the open issues by label badge and it's neither saying the write thing on the badge nor showing the right number. Would you be able to fix this anytime soon?

I also wonder if we only want those badges for issues, and then just have a single badge for all open PRs. The PR list has never, to my knowledge, gotten longer than a page, and has only briefly been over 10 at the height of reworking Hyper-Schema. I feel like one click is better than multiple for PRs.

@Relequestual
Copy link
Member

Yeah I'll get on this. I'm most likely to fix this in one weeks time as we have a limited time on Friday morning for work. I'll make a reminder to make sure I do it. =]

@Relequestual
Copy link
Member

adds another reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants