Skip to content

Bug: Search button is not as expected in responsive mode. #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DhairyaMajmudar opened this issue Feb 23, 2024 · 7 comments · Fixed by #359
Closed

Bug: Search button is not as expected in responsive mode. #345

DhairyaMajmudar opened this issue Feb 23, 2024 · 7 comments · Fixed by #359
Assignees
@DhairyaMajmudar
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@DhairyaMajmudar
Copy link
Member

Describe the bug

In the tablet and mobile view, the search button is not as expected which needed to be corrected.

How to Reproduce

  1. Open the JSON Schema website
  2. Use developer tools access the tablet and mobile view

Screenshots

  • Tablet
    Screenshot from 2024-02-23 23-47-31

  • Mobile
    Screenshot from 2024-02-23 23-47-18

Expected behavior

The search button must be the same as in the desktop view.
@DhairyaMajmudar
Copy link
Member Author

@benjagm pls. have a look on this bug.

@benjagm benjagm added 🐛 Bug Indicates that the issue is a bug or defect. Status: Triage This is the initial status for an issue that requires triage. labels Feb 23, 2024
@benjagm
Copy link
Collaborator

benjagm commented Feb 23, 2024

Thanks for finding this bug.

Please go ahead with the fix.

@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Triage This is the initial status for an issue that requires triage. labels Feb 23, 2024
@DhairyaMajmudar DhairyaMajmudar mentioned this issue Feb 25, 2024
Merged
@benjagm benjagm mentioned this issue Feb 26, 2024
Closed
@benjagm
Copy link
Collaborator

benjagm commented Feb 26, 2024 •
edited
Loading

@DhairyaMajmudar Please see this comment in #355

@DhairyaMajmudar DhairyaMajmudar changed the title Search button is not as expected in responsive mode. Bug:Search button is not as expected in responsive mode. Mar 1, 2024
@DhairyaMajmudar DhairyaMajmudar changed the title Bug:Search button is not as expected in responsive mode. Bug: Search button is not as expected in responsive mode. Mar 1, 2024
@officeneerajsaini
Copy link
Contributor

Hey @DhairyaMajmudar , maybe we need to change the text on this button. Instead of displaying 'Search,' we can display 'Quick Search (Ctrl + K)' to inform the user that they can use this key combination for quick search.

Screenshot from 2024-03-12 10-20-31

@DhairyaMajmudar
Copy link
Member Author

Good idea Neeraj, but by adding more text in search bar will increase its width as you can see in the image above.

@officeneerajsaini
Copy link
Contributor

Yes Dhairya

@benjagm
Copy link
Collaborator

benjagm commented Mar 12, 2024

The idea is to convert the search button in a single lens icon button like AsyncAPI does. https://www.asyncapi.com/en

This is in progress as part of #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DhairyaMajmudar DhairyaMajmudar

Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Fixing search bar in responsive screens. DhairyaMajmudar/json-schema-website
3 participants
@benjagm @officeneerajsaini @DhairyaMajmudar