Skip to content

box shadow when the hamburger menu in mobile design is open #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Akshaybagai52 opened this issue Feb 27, 2024 · 2 comments · Fixed by #359
Closed

box shadow when the hamburger menu in mobile design is open #374

Akshaybagai52 opened this issue Feb 27, 2024 · 2 comments · Fixed by #359
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Available No one has claimed responsibility for resolving this issue.

Comments

@Akshaybagai52
Copy link
Contributor

Reason/Context

We need this improvement for better user experience

Description

go to this url :-https://json-schema.org/ and turn on mobile responsive
then you can see there is drop shadow on navbar when it is not open so it is looking good
Screenshot 2024-02-27 at 10 02 40 AM

but when the navbar is open on clicking of hamburger menu then the box shadow removed and it is merging with the white background of the content as can be seen in the screenshot
Screenshot 2024-02-27 at 10 04 06 AM

so there is no separation between navbar and content.

Do you think this work might require an Architectural Decision Record (ADR)? (significant or noteworthy)

Yes/No
[JUSTIFICATION]

I would love to work on this issue

@DhairyaMajmudar
Copy link
Member

@benjagm shall I incorporate this small change in my existing PR #359

Screenshot after changes

image

@benjagm
Copy link
Collaborator

benjagm commented Feb 27, 2024

thanks @Akshaybagai52 for finding this!

@benjagm benjagm added 🐛 Bug Indicates that the issue is a bug or defect. Status: Available No one has claimed responsibility for resolving this issue. labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Available No one has claimed responsibility for resolving this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants