-
-
Notifications
You must be signed in to change notification settings - Fork 271
🐛 Bug: Improve behaviour of Draft 2020-12 for mobile devices #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@benjagm Shall I take this up : D |
@benjagm I test the changes the code was working fine for these components what extra you're looking forward to here |
Actually the website page is getting overflow in x direction which needed to be fixed. |
I fixed that issue too or maybe it will get fixed once the changes are applied to all the components. |
@benjagm I was going to fix this overflow issue too |
@benjagm Can I work on this issue! |
Hi there @benjagm !, I tried reproducing the bug but seems like the page isn't available on the production link. It's showing a 404 error. |
@benjagm Can you please assign me this issue |
Also while inspecting the bug it was found that this buggy behaviour is visible in all the pages of specifications section. |
Yeah this is due to two different components for styling one jsonEditor and one styledMarkdown. |
I would like to work on this issue. I looked into it and the li and th is the major reason for that overflow if we make that responsive it will solve the whole issue. |
@Adity20 is fixing the problems with the code editor.
Please try https://json-schema.org/draft/2020-12/release-notes |
@Adity20 is working on aligning the code components. This issue is just to change the tables behaviour for mobile in the the page 2020-12/release-notes. @AdityaSingh-02 please go ahead with this one. |
Describe the bug
The page with the release notes for draft 2020-12: https://json-schema.org/draft/2020-12/release-notes does not work well for mobile devices. The hold school tables producing a huge horizontal overflow.
Steps To Reproduce
Expected Behavior
The ideal solution for me is a grid that when it reaches the breaking point converts that 1 row x 2 columns approach into a 2 rows x 1 column so we avoid the overflow to happen.
Screenshots
No response
Device Information [optional]
Are you working on this issue?
No
Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)
No
The text was updated successfully, but these errors were encountered: