Skip to content

🐛 Bug: Improve behaviour of Draft 2020-12 for mobile devices #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjagm opened this issue Mar 8, 2024 · 13 comments · Fixed by #498
Closed

🐛 Bug: Improve behaviour of Draft 2020-12 for mobile devices #483

benjagm opened this issue Mar 8, 2024 · 13 comments · Fixed by #498
Assignees
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@benjagm
Copy link
Collaborator

benjagm commented Mar 8, 2024

Describe the bug

The page with the release notes for draft 2020-12: https://json-schema.org/draft/2020-12/release-notes does not work well for mobile devices. The hold school tables producing a huge horizontal overflow.

Screenshot 2024-03-08 at 18 34 38

Steps To Reproduce

  1. Go to https://json-schema.org/draft/2020-12/release-notes
  2. Use developer tools to navigate like a mobile
  3. Check the unnecessary horizontal overflow

Expected Behavior

The ideal solution for me is a grid that when it reaches the breaking point converts that 1 row x 2 columns approach into a 2 rows x 1 column so we avoid the overflow to happen.

Screenshots

No response

Device Information [optional]

- OS:
- Browser:
- version:

Are you working on this issue?

No

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No

@benjagm benjagm added 🐛 Bug Indicates that the issue is a bug or defect. Status: Triage This is the initial status for an issue that requires triage. labels Mar 8, 2024
@benjagm benjagm added Status: Available No one has claimed responsibility for resolving this issue. and removed Status: Triage This is the initial status for an issue that requires triage. labels Mar 8, 2024
@benjagm benjagm moved this to Waiting for Contributions in Website Contributor Board Mar 8, 2024
@DhairyaMajmudar
Copy link
Member

@benjagm Shall I take this up : D

@Adity20
Copy link
Contributor

Adity20 commented Mar 8, 2024

@benjagm I test the changes the code was working fine for these components what extra you're looking forward to here

@DhairyaMajmudar
Copy link
Member

Actually the website page is getting overflow in x direction which needed to be fixed.

@Adity20
Copy link
Contributor

Adity20 commented Mar 8, 2024

I fixed that issue too or maybe it will get fixed once the changes are applied to all the components.

@Adity20
Copy link
Contributor

Adity20 commented Mar 8, 2024

@benjagm I was going to fix this overflow issue too
So if it's fine for you I can work on this too as I know what changes need to be made for this
I'm done with one task assigned already so left with this one only

@VivekJaiswal18
Copy link
Contributor

@benjagm Can I work on this issue!

@ayushtiwari110
Copy link
Contributor

Hi there @benjagm !, I tried reproducing the bug but seems like the page isn't available on the production link. It's showing a 404 error.

@AdityaSingh-02
Copy link
Contributor

@benjagm Can you please assign me this issue

@DhairyaMajmudar
Copy link
Member

Also while inspecting the bug it was found that this buggy behaviour is visible in all the pages of specifications section.

@Adity20
Copy link
Contributor

Adity20 commented Mar 9, 2024

Yeah this is due to two different components for styling one jsonEditor and one styledMarkdown.

@Sahil-Shadwal
Copy link
Contributor

I would like to work on this issue. I looked into it and the li and th is the major reason for that overflow if we make that responsive it will solve the whole issue.

@benjagm
Copy link
Collaborator Author

benjagm commented Mar 9, 2024

@Adity20 is fixing the problems with the code editor.

Hi there @benjagm !, I tried reproducing the bug but seems like the page isn't available on the production link. It's showing a 404 error.

Please try https://json-schema.org/draft/2020-12/release-notes

@benjagm
Copy link
Collaborator Author

benjagm commented Mar 9, 2024

@Adity20 is working on aligning the code components.

This issue is just to change the tables behaviour for mobile in the the page 2020-12/release-notes. @AdityaSingh-02 please go ahead with this one.

@benjagm benjagm moved this from Waiting for Contributions to In Progress in Website Contributor Board Mar 9, 2024
@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Available No one has claimed responsibility for resolving this issue. labels Mar 9, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in Website Contributor Board Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants