Skip to content

🐛 Bug: Fix spacing in icon buttons of the header #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjagm opened this issue Mar 13, 2024 · 10 comments
Closed

🐛 Bug: Fix spacing in icon buttons of the header #535

benjagm opened this issue Mar 13, 2024 · 10 comments
Assignees
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@benjagm
Copy link
Collaborator

benjagm commented Mar 13, 2024

Describe the bug

The new header in the dark theme includes an button for search and another for switch dark theme but the spacing needs extra work for both desktop and mobile.

Desktop:
Screenshot 2024-03-13 at 17 45 42

Mobile:
Screenshot 2024-03-13 at 17 45 48

Steps To Reproduce

Just open the json schema website.

Expected Behavior

optimal spacing.

Screenshots

No response

Device Information [optional]

- OS:
- Browser:
- version:

Are you working on this issue?

No

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No

@benjagm benjagm added 🐛 Bug Indicates that the issue is a bug or defect. Status: On Hold Similar to blocked, but is assigned to someone. labels Mar 13, 2024
@Akshaybagai52
Copy link
Contributor

Hello @benjagm
can I work on this issue

@AdityaSingh-02
Copy link
Contributor

Heyy @benjagm, Please assign me this issue 🚀

@VivekJaiswal18
Copy link
Contributor

@benjagm Can you eleborate what needs to be done here. As when I checked it was looking ok

@benjagm
Copy link
Collaborator Author

benjagm commented Mar 13, 2024

This issue is on hold to be fixed when we have back the dark theme feature

@Adity20
Copy link
Contributor

Adity20 commented Mar 16, 2024

I would like to fix this once we are back with the dark theme.

@satyam-x10
Copy link
Contributor

@benjagm can i work on this one. Thanks

@AjayAsnani
Copy link

Hey @benjagm Can you assign this issue to me

@benjagm
Copy link
Collaborator Author

benjagm commented Mar 18, 2024

@Akshaybagai52 please go ahead with this issue.

@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: On Hold Similar to blocked, but is assigned to someone. labels Mar 18, 2024
@benjagm benjagm moved this to In Progress in Website Contributor Board Mar 18, 2024
@Akshaybagai52
Copy link
Contributor

@Akshaybagai52 please go ahead with this issue.

This is the PR #575

@benjagm
Copy link
Collaborator Author

benjagm commented Apr 11, 2024

Closed as completed.

@benjagm benjagm closed this as completed Apr 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in Website Contributor Board Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

No branches or pull requests

7 participants