Skip to content

Commit e44d485

Browse files
dcantahjsturtevant
authored andcommitted
Revert "Downgrade MinGW to version 10.2.0"
This reverts commit 1ef4bda. Previously we were downgrading mingw to work around an issue in the race detector in Go on Windows when used with a newer version of GCC. The issue was first reported here: golang/go#46099 Shortly after the release of 1.19 someone had commented this issue was solved for them, and after trying it out in some test runs on actions machines, it seems to be the case. Disabling ASLR got things in order, and PIE was disabled for -race builds in 1.19, so this is likely the reason things work now: golang/go@0c7fcf6. The downgrade was mostly harmless except for two shortcomings: 1. It took quite a while for the package to get downloaded+installed. 2. Chocolatey would frequently fail to download with `The remote file either doesn't exist, is unauthorized, or is forbidden for url ... Exception calling "GetResponse" with "0" argument(s): "The request was aborted: Could not create SSL/TLS secure channel."` Restarting the failed run would often resolve this, but a 50-50 shot of things working is not a great situation. Signed-off-by: Daniel Canter <[email protected]>
1 parent 8233867 commit e44d485

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

.github/workflows/ci.yml

-8
Original file line numberDiff line numberDiff line change
@@ -286,14 +286,6 @@ jobs:
286286
287287
- run: script/setup/install-dev-tools
288288

289-
# There is currently an issue in the race detector in Go on Windows when
290-
# used with a newer version of GCC. The issue was first reported here:
291-
# https://github.com/golang/go/issues/46099
292-
- name: Downgrade MinGW
293-
shell: bash
294-
run: |
295-
choco install mingw --version 10.2.0 --allow-downgrade
296-
297289
- name: Binaries
298290
env:
299291
CGO_ENABLED: 1

0 commit comments

Comments
 (0)