Skip to content

Commit 8d8f016

Browse files
jessebeachljharb
authored andcommitted
[Fix] pin aria-query and axe-core to fix failing tests on main
For `axe-core`, see dequelabs/axe-core#4127
1 parent f0d2ddb commit 8d8f016

File tree

4 files changed

+3
-5
lines changed

4 files changed

+3
-5
lines changed

__mocks__/genInteractives.js

-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ const interactiveElementsMap = {
4949
menuitem: [],
5050
option: [],
5151
select: [],
52-
summary: [],
5352
// Whereas ARIA makes a distinction between cell and gridcell, the AXObject
5453
// treats them both as CellRole and since gridcell is interactive, we consider
5554
// cell interactive as well.

__tests__/src/rules/no-interactive-element-to-noninteractive-role-test.js

-1
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,6 @@ const neverValid = [
369369
{ code: '<menuitem role="listitem" />;', errors: [expectedError] },
370370
{ code: '<option className="foo" role="listitem" />', errors: [expectedError] },
371371
{ code: '<select className="foo" role="listitem" />', errors: [expectedError] },
372-
{ code: '<summary role="listitem" />;', errors: [expectedError] },
373372
{ code: '<textarea className="foo" role="listitem" />', errors: [expectedError] },
374373
{ code: '<tr role="listitem" />;', errors: [expectedError] },
375374
/* Custom elements */

__tests__/src/rules/no-static-element-interactions-test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,6 @@ const alwaysValid = [
157157
{ code: '<ruby onClick={() => {}} />;' },
158158
{ code: '<section onClick={() => {}} aria-label="Aa" />;' },
159159
{ code: '<section onClick={() => {}} aria-labelledby="js_1" />;' },
160-
{ code: '<summary onClick={() => {}} />;' },
161160
{ code: '<table onClick={() => {}} />;' },
162161
{ code: '<tbody onClick={() => {}} />;' },
163162
{ code: '<tfoot onClick={() => {}} />;' },
@@ -340,6 +339,7 @@ const neverValid = [
340339
{ code: '<style onClick={() => {}} />;', errors: [expectedError] },
341340
{ code: '<sub onClick={() => {}} />;', errors: [expectedError] },
342341
{ code: '<sup onClick={() => {}} />;', errors: [expectedError] },
342+
{ code: '<summary onClick={() => {}} />;', errors: [expectedError] },
343343
{ code: '<title onClick={() => {}} />;', errors: [expectedError] },
344344
{ code: '<track onClick={() => {}} />;', errors: [expectedError] },
345345
{ code: '<tt onClick={() => {}} />;', errors: [expectedError] },

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,11 @@
7373
"license": "MIT",
7474
"dependencies": {
7575
"@babel/runtime": "^7.20.7",
76-
"aria-query": "^5.1.3",
76+
"aria-query": "=5.1.3",
7777
"array-includes": "^3.1.6",
7878
"array.prototype.flatmap": "^1.3.1",
7979
"ast-types-flow": "^0.0.7",
80-
"axe-core": "^4.6.2",
80+
"axe-core": "=4.7.0",
8181
"axobject-query": "^3.1.1",
8282
"damerau-levenshtein": "^1.0.8",
8383
"emoji-regex": "^9.2.2",

0 commit comments

Comments
 (0)