Skip to content

Commit 2b6e529

Browse files
committed
[Tests] no-typos: uncomment test case and use semver to conditionally run it
1 parent 0636a8b commit 2b6e529

File tree

1 file changed

+19
-13
lines changed

1 file changed

+19
-13
lines changed

tests/lib/rules/no-typos.js

Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
const babelEslintVersion = require('babel-eslint/package.json').version;
1212
const semver = require('semver');
13+
const version = require('eslint/package.json').version;
1314
const RuleTester = require('eslint').RuleTester;
1415

1516
const rule = require('../../../lib/rules/no-typos');
@@ -714,7 +715,8 @@ ruleTester.run('no-typos', rule, {
714715
MyComponent.defaultProps = { value: "" };
715716
`,
716717
parserOptions,
717-
}, semver.satisfies(babelEslintVersion, '>= 9') ? {
718+
},
719+
semver.satisfies(babelEslintVersion, '>= 9') ? {
718720
code: `
719721
class Editor extends React.Component {
720722
#somethingPrivate() {
@@ -2413,20 +2415,24 @@ ruleTester.run('no-typos', rule, {
24132415
type: 'Property',
24142416
},
24152417
],
2416-
/*
2418+
},
2419+
semver.satisfies(version, '^5') ? {
24172420
// PropTypes declared on a component that is detected through JSDoc comments and is
24182421
// declared AFTER the PropTypes assignment
2419-
// Commented out since it only works with eslint 5.
2420-
,{
2421-
code: `
2422-
MyComponent.PROPTYPES = {}
2423-
\/** @extends React.Component *\/
2424-
class MyComponent extends BaseComponent {}
2425-
`,
2426-
parserOptions: parserOptions
2427-
},
2428-
*/
2429-
}, parsers.TS([
2422+
code: `
2423+
MyComponent.PROPTYPES = {}
2424+
/** @extends React.Component */
2425+
class MyComponent extends BaseComponent {}
2426+
`,
2427+
parserOptions,
2428+
errors: [
2429+
{
2430+
ruleId: 'no-typos',
2431+
messageId: 'typoStaticClassProp',
2432+
},
2433+
],
2434+
} : [],
2435+
parsers.TS([
24302436
{
24312437
code: `
24322438
import 'prop-types'

0 commit comments

Comments
 (0)