[Perf] component detection: improve performance by optimizing getId

golopot · ljharb · commit 5baa3e0fb7cf · 2022-10-06T17:20:32.000+08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,7 +13,9 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 
 ### Changed
 * [Docs] [`no-unknown-property`]: fix typo in link ([#3445][] @denkristoffer)
+* [Perf] component detection: improve performance by optimizing getId ([#3451][] @golopot)
 
+[#3451]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3451
 [#3448]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3448
 [#3445]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3445
 [#3436]: https://github.com/jsx-eslint/eslint-plugin-react/issues/3436
diff --git a/lib/util/Components.js b/lib/util/Components.js
@@ -21,7 +21,7 @@ const isFirstLetterCapitalized = require('./isFirstLetterCapitalized');
 const isDestructuredFromPragmaImport = require('./isDestructuredFromPragmaImport');
 
 function getId(node) {
-  return node && node.range.join(':');
+  return node ? `${node.range[0]}:${node.range[1]}` : '';
 }
 
 function usedPropTypesAreEquivalent(propA, propB) {

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ const isFirstLetterCapitalized = require('./isFirstLetterCapitalized');`
`21`	`21`	`const isDestructuredFromPragmaImport = require('./isDestructuredFromPragmaImport');`
`22`	`22`
`23`	`23`	`function getId(node) {`
`24`		`- return node && node.range.join(':');`
	`24`	+ return node ? `${node.range[0]}:${node.range[1]}` : '';
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`function usedPropTypesAreEquivalent(propA, propB) {`