Skip to content

Commit cfabdce

Browse files
MichaelDeBoeyMichaelDeBoey
committed
feat: drop Node 4, 6, 8, 10, 12, 14 & 16 support
BREAKING CHANGE: Requires Node@^18.18.0 || ^20.9.0 || >=21.1.0
1 parent 3a03579 commit cfabdce

File tree

167 files changed

+478
-620
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

167 files changed

+478
-620
lines changed

Diff for: ‎.eslintrc

+3-11
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"node": true
88
},
99
"parserOptions": {
10-
"ecmaVersion": 6,
10+
"ecmaVersion": 2022,
1111
"ecmaFeatures": {
1212
"jsx": true
1313
},
@@ -34,17 +34,10 @@
3434
"consistent-return": 0,
3535

3636
"prefer-destructuring": [2, { "array": false, "object": false }, { "enforceForRenamedProperties": false }],
37-
"prefer-object-spread": 0, // until node 8 is required
38-
"prefer-rest-params": 0, // until node 6 is required
39-
"prefer-spread": 0, // until node 6 is required
40-
"function-call-argument-newline": 1, // TODO: enable
37+
"function-call-argument-newline": 1,
4138
"function-paren-newline": 0,
4239
"no-plusplus": [2, {"allowForLoopAfterthoughts": true}],
4340
"no-param-reassign": 1,
44-
"no-restricted-syntax": [2, {
45-
"selector": "ObjectPattern",
46-
"message": "Object destructuring is not compatible with Node v4"
47-
}],
4841
"strict": [2, "safe"],
4942
"valid-jsdoc": [2, {
5043
"requireReturn": false,
@@ -73,12 +66,11 @@
7366
{
7467
"files": ".github/workflows/*.js",
7568
"parserOptions": {
76-
"ecmaVersion": 2019,
69+
"ecmaVersion": 2022,
7770
},
7871
"rules": {
7972
"camelcase": 0,
8073
"no-console": 0,
81-
"no-restricted-syntax": 0,
8274
},
8375
},
8476
],

Diff for: ‎.github/workflows/node-minors.yml

-117
This file was deleted.

Diff for: ‎.github/workflows/node-18+.yml renamed to ‎.github/workflows/node.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: 'Tests: node.js (18+)'
1+
name: 'Tests: node.js'
22

33
on: [pull_request, push]
44

@@ -14,7 +14,7 @@ jobs:
1414
with:
1515
versionsAsRoot: true
1616
type: majors
17-
preset: '>=18'
17+
preset: '^18.18.0 || ^20.9.0 || >=21.1.0'
1818

1919
latest:
2020
needs: [matrix]

Diff for: ‎lib/rules/boolean-prop-naming.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ module.exports = {
260260
}
261261

262262
const annotationTypeArguments = propsUtil.getTypeArguments(
263-
component.node.parent.id.typeAnnotation.typeAnnotation
263+
component.node.parent.id.typeAnnotation.typeAnnotation,
264264
);
265265
if (
266266
annotationTypeArguments && (
@@ -269,7 +269,7 @@ module.exports = {
269269
)
270270
) {
271271
return annotationTypeArguments.params.find(
272-
(param) => param.type === 'TSTypeReference' || param.type === 'GenericTypeAnnotation'
272+
(param) => param.type === 'TSTypeReference' || param.type === 'GenericTypeAnnotation',
273273
);
274274
}
275275
}
@@ -278,7 +278,7 @@ module.exports = {
278278
if (node.type === 'TSTypeLiteral' || node.type === 'ObjectTypeAnnotation' || node.type === 'TSInterfaceBody') {
279279
const currentNode = [].concat(
280280
objectTypeAnnotations.get(identifier.name) || [],
281-
node
281+
node,
282282
);
283283
objectTypeAnnotations.set(identifier.name, currentNode);
284284
} else if (
@@ -317,7 +317,7 @@ module.exports = {
317317
&& astUtil.isCallExpression(node.value)
318318
&& propWrapperUtil.isPropWrapperFunction(
319319
context,
320-
getText(context, node.value.callee)
320+
getText(context, node.value.callee),
321321
)
322322
) {
323323
checkPropWrapperArguments(node, node.value.arguments);
@@ -343,7 +343,7 @@ module.exports = {
343343
astUtil.isCallExpression(right)
344344
&& propWrapperUtil.isPropWrapperFunction(
345345
context,
346-
getText(context, right.callee)
346+
getText(context, right.callee),
347347
)
348348
) {
349349
checkPropWrapperArguments(component.node, right.arguments);
@@ -407,7 +407,7 @@ module.exports = {
407407
[].concat(propType).filter(Boolean).forEach((prop) => {
408408
validatePropNaming(
409409
component.node,
410-
prop.properties || prop.members || prop.body
410+
prop.properties || prop.members || prop.body,
411411
);
412412
});
413413
}

Diff for: ‎lib/rules/button-has-type.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ module.exports = {
6161
},
6262

6363
create(context) {
64-
const configuration = Object.assign({}, optionDefaults, context.options[0]);
64+
const configuration = { ...optionDefaults, ...context.options[0] };
6565

6666
function reportMissing(node) {
6767
report(context, messages.missingType, 'missingType', {

Diff for: ‎lib/rules/checked-requires-onchange-or-readonly.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ function extractTargetProps(properties, keyName) {
3636
prop[keyName] && targetPropSet.has(prop[keyName].name)
3737
? [prop[keyName].name]
3838
: []
39-
)
40-
)
39+
),
40+
),
4141
);
4242
}
4343

@@ -64,14 +64,14 @@ module.exports = {
6464
}],
6565
},
6666
create(context) {
67-
const options = Object.assign({}, defaultOptions, context.options[0]);
67+
const options = { ...defaultOptions, ...context.options[0] };
6868

6969
function reportMissingProperty(node) {
7070
report(
7171
context,
7272
messages.missingProperty,
7373
'missingProperty',
74-
{ node }
74+
{ node },
7575
);
7676
}
7777

@@ -80,7 +80,7 @@ module.exports = {
8080
context,
8181
messages.exclusiveCheckedAttribute,
8282
'exclusiveCheckedAttribute',
83-
{ node }
83+
{ node },
8484
);
8585
}
8686

Diff for: ‎lib/rules/default-props-match-prop-types.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ module.exports = {
100100
.forEach((component) => {
101101
reportInvalidDefaultProps(
102102
component.declaredPropTypes,
103-
component.defaultProps || {}
103+
component.defaultProps || {},
104104
);
105105
});
106106
},

Diff for: ‎lib/rules/display-name.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ module.exports = {
276276
// Report missing display name for all context objects
277277
forEach(
278278
filter(contextObjects.values(), (v) => !v.hasDisplayName),
279-
(contextObj) => reportMissingContextDisplayName(contextObj)
279+
(contextObj) => reportMissingContextDisplayName(contextObj),
280280
);
281281
}
282282
},

Diff for: ‎lib/rules/forbid-component-props.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ module.exports = {
179179
}
180180

181181
return options.allowPatternList.every(
182-
(pattern) => !minimatch(tagName, pattern)
182+
(pattern) => !minimatch(tagName, pattern),
183183
);
184184
}
185185

@@ -193,7 +193,7 @@ module.exports = {
193193
}
194194

195195
return options.disallowPatternList.some(
196-
(pattern) => minimatch(tagName, pattern)
196+
(pattern) => minimatch(tagName, pattern),
197197
);
198198
}
199199

Diff for: ‎lib/rules/forbid-elements.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ module.exports = {
8686
element,
8787
message,
8888
},
89-
}
89+
},
9090
);
9191
}
9292
}

Diff for: ‎lib/rules/forward-ref-uses-ref.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -78,18 +78,18 @@ module.exports = {
7878
const shouldAddParentheses = node.type === 'ArrowFunctionExpression' && !isParenthesized(context, param);
7979
return [].concat(
8080
shouldAddParentheses ? fixer.insertTextBefore(param, '(') : [],
81-
fixer.insertTextAfter(param, `, ref${shouldAddParentheses ? ')' : ''}`)
81+
fixer.insertTextAfter(param, `, ref${shouldAddParentheses ? ')' : ''}`),
8282
);
8383
},
84-
}
84+
},
8585
),
8686
Object.assign(
8787
getMessageData('removeForwardRef', messages.removeForwardRef),
8888
{
8989
fix(fixer) {
9090
return fixer.replaceText(node.parent, sourceCode.getText(node));
9191
},
92-
}
92+
},
9393
),
9494
],
9595
});

Diff for: ‎lib/rules/function-component-definition.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const propsUtil = require('../util/props');
1919
function buildFunction(template, parts) {
2020
return Object.keys(parts).reduce(
2121
(acc, key) => acc.replace(`{${key}}`, () => parts[key] || ''),
22-
template
22+
template,
2323
);
2424
}
2525

@@ -72,7 +72,7 @@ function getParams(node, source) {
7272
if (node.params.length === 0) return null;
7373
return source.slice(
7474
node.params[0].range[0],
75-
node.params[node.params.length - 1].range[1]
75+
node.params[node.params.length - 1].range[1],
7676
);
7777
}
7878

@@ -176,10 +176,10 @@ module.exports = {
176176
let fileVarType = 'var';
177177

178178
const namedConfig = [].concat(
179-
configuration.namedComponents || 'function-declaration'
179+
configuration.namedComponents || 'function-declaration',
180180
);
181181
const unnamedConfig = [].concat(
182-
configuration.unnamedComponents || 'function-expression'
182+
configuration.unnamedComponents || 'function-expression',
183183
);
184184

185185
function getFixer(node, options) {
@@ -214,7 +214,7 @@ module.exports = {
214214
body: getBody(node, source),
215215
name: getName(node),
216216
varType,
217-
})
217+
}),
218218
);
219219
}
220220

0 commit comments

Comments
 (0)