Support no_proxy environment variable

octokit uses faraday for making http_request.
There is a long standing issue in faraday to add support for the no_proxy environment variable: lostisland/faraday#247
Unfortuantely it seems like this is going nowhere.
A workaround is suggested in this issue: berkshelf/berkshelf#1341

The httpclient (and excon) farady adapter picks up proxy settings from the environment automatically.

Author: databus23

Diff for: Dockerfile

@@ -8,7 +8,7 @@ RUN apk add --update \
   openssh-client \
   ruby-json \
   ca-certificates
-RUN gem install octokit --no-rdoc --no-ri
+RUN gem install octokit httpclient --no-rdoc --no-ri
 
 ADD assets/ /opt/resource/
 RUN chmod +x /opt/resource/*

Diff for: Gemfile

@@ -2,6 +2,7 @@
 source 'https://rubygems.org'
 
 gem 'octokit'
+gem 'httpclient'
 
 group :development do
   gem 'pry'

Diff for: Gemfile.lock

@@ -21,6 +21,7 @@ GEM
     faraday (0.9.2)
       multipart-post (>= 1.2, < 3)
     http_parser.rb (0.6.0)
+    httpclient (2.8.0)
     method_source (0.8.2)
     multi_json (1.11.2)
     multipart-post (2.0.0)
@@ -73,6 +74,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  httpclient
   octokit
   pry
   puffing-billy

Diff for: assets/lib/check.rb

@@ -3,8 +3,8 @@
 
 require 'rubygems'
 require 'json'
-require 'octokit'
 require_relative 'common'
+require 'octokit'
 
 repo = Repository.new(name: input['source']['repo'])
 

Diff for: assets/lib/common.rb

@@ -1,4 +1,10 @@
 # encoding: utf-8
+
+require 'faraday'
+# httpclient and excon are the only Faraday adpater which support
+# the no_proxy environment variable atm
+::Faraday.default_adapter= :httpclient
+
 require 'octokit'
 require 'fileutils'
 

Diff for: assets/lib/in.rb

@@ -5,9 +5,9 @@
 
 require 'rubygems'
 require 'json'
+require_relative 'common'
 require 'octokit'
 require 'English'
-require_relative 'common'
 
 def uri
   input['source']['uri'] || "https://github.com/#{input['source']['repo']}"

Diff for: assets/lib/out.rb

@@ -5,8 +5,8 @@
 
 require 'rubygems'
 require 'json'
-require 'octokit'
 require_relative 'common'
+require 'octokit'
 
 raise %(`status` "#{input['params']['status']}" is not supported -- only success, failure, error, or pending) unless %w(success failure error pending).include?(input['params']['status'])
 raise '`path` required in `params`' unless input['params'].key?('path')