Skip to content
This repository was archived by the owner on Nov 8, 2018. It is now read-only.

support the trigger: every for a get #15

Closed
jtarchie opened this issue Apr 29, 2016 · 5 comments
Closed

support the trigger: every for a get #15

jtarchie opened this issue Apr 29, 2016 · 5 comments

Comments

@jtarchie
Copy link
Owner

jtarchie commented Apr 29, 2016

I'd like to migrate the resource to only support the new feature with concourse v1.2 version: every. This allows the resource to iterated over without having to check the github status for state.

I'd like to give a migration path, though.

I'm thinking of making the feature an opt in feature for now via source so the check step return all versions.

If the source value was not provided a deprecation notice will be displayed, which will warn about the impending change.

@jtarchie
Copy link
Owner Author

Just a head's up, this is coming down the pipeline!

@ahelal
Copy link

ahelal commented Jul 13, 2016

Haa i was about to open an ISSUE :)

@jtarchie
Copy link
Owner Author

jtarchie commented Jul 23, 2016

I've push out the changes. They should work with any version of concourse 1.2.x and greater. It will deprecate the need to set a status, so the next PR can be iterated.

I would love someone to try it out. It will be an opt-in feature. It only affects the check step, the other steps don't change.

cc: @ahelal, @everpeace, and @pierrebeaucamp

@everpeace
Copy link
Contributor

everpeace commented Jul 24, 2016

@jtarchie Thanks for the update!! I just tested version: every in my local concourse. This works like a charm :-) I commented a small thing here.

@jtarchie
Copy link
Owner Author

jtarchie commented Aug 9, 2016

I'm closing this as the beta feature seems to be working for people.

Please feel free to open a new issue if you're having problems with it.

@jtarchie jtarchie closed this as completed Aug 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants