Can retrieve PRs from a specified base branch #25
Conversation
Modify existing test to assert on params, to ensure we don't unnecessarily request an empty base when default base is desired.
| def must_stub_query_params | ||
| around do |example| | ||
| old_strip_params = Billy.config.strip_query_params | ||
| Billy.config.strip_query_params = false |
There was a problem hiding this comment.
I didn't know this was a thing. I'm going to turn this on for everything!
There was a problem hiding this comment.
Yeah, otherwise we're only asserting on path, which could miss a lot of mistakes.
|
Do you know if |
|
You can't create a PR against multiple branches, so no. The API docs aren't explicit about it, but don't give examples of multiples: |
|
Oh, I see. You might get a feature request to filter by multiple branches. I guess we'd need to do that ourselves. |
|
Let's keep it as is. I just wanted to confirm that it only takes one branch. |
|
LGTM! to borrow from @flavorjones |
This adds a
base: mybranchnameoption tosource. The GitHub API is then called withbase=mybranchnamewhen retrieving new versions.Modify existing test to assert on params, to ensure we don't
unnecessarily request an empty base when default base is desired.
I've tested this on https://ci.rabbitmq.com/. For reference, it was the
rabbitmq_trust_store_prresource.base: masteron a PR resource usingcamelpunch/pr.masterbranch.stablebranch.Only the
masterbranch PR tests were run, which was as expected.