Skip to content
This repository was archived by the owner on Jul 28, 2023. It is now read-only.

Move to the jupyter-resource-usage repo #51

Closed
jtpio opened this issue Nov 26, 2020 · 3 comments · Fixed by #104
Closed

Move to the jupyter-resource-usage repo #51

jtpio opened this issue Nov 26, 2020 · 3 comments · Fixed by #104

Comments

@jtpio
Copy link
Owner

jtpio commented Nov 26, 2020

The lab extensions provided in this repo should eventually be moved to https://github.com/jupyter-server/jupyter-resource-usage.

This will avoid having an external dependency on nbresuse / jupyter-resource-usage.

And using the new distribution system for federated / pre-built extensions in JupyterLab 3.0, it will be easier to have everything installed and working with a single pip install jupyter-resource-usage.

There is on-going work to move the status bar item from core lab to jupyter-resource-usage: jupyter-server/jupyter-resource-usage#69

Regarding the dependency on the topbar plugin, this could be made optional. With https://github.com/jtpio/jupyterlab-topbar staying as-is and providing the token. For example:

  • Check jupyterlab-topbar is installed and the ITopBar token is available. If so, add the indicators to the topbar just like now.
  • If not available, add the indicators to the top area instead with app.shell(widget, 'top')

This way users will only get the functionality if they ask for it with pip install jupyterlab-topbar.

@dclong
Copy link

dclong commented Feb 22, 2021

The issue jupyter-server/jupyter-resource-usage#69 has been merged. Does it mean that jupyter-resource-usage is preferred over jupyterab-system-monitor now?

@jtpio
Copy link
Owner Author

jtpio commented Feb 22, 2021

Does it mean that jupyter-resource-usage is preferred over jupyterab-system-monitor now?

Not yet. For now jupyter-resource-usage only adds the status bar indicator for JupyterLab.

With this issue the idea would be to move the visual top bar indicator to jupyter-resource-usage:

image

Then when it's done users could do a single pip install jupyter-resource-usage to insall everything at once.

@jtpio
Copy link
Owner Author

jtpio commented Jul 28, 2023

Closing as jupyterlab-system-monitor has now been integrated in jupyter-resource-usage: jupyter-server/jupyter-resource-usage#191

@jtpio jtpio closed this as completed Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants