Skip to content

Commit 550654a

Browse files
committed
Add OrderingRequest, to ensure orderWith() orders once
1 parent 9d1e2aa commit 550654a

File tree

1 file changed

+3
-16
lines changed

1 file changed

+3
-16
lines changed

src/main/java/org/junit/runner/Request.java

+3-16
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
package org.junit.runner;
22

3-
import java.util.Collection;
43
import java.util.Comparator;
54

65
import org.junit.internal.builders.AllDefaultPossibilitiesBuilder;
76
import org.junit.internal.requests.ClassRequest;
87
import org.junit.internal.requests.FilterRequest;
8+
import org.junit.internal.requests.OrderingRequest;
99
import org.junit.internal.requests.SortingRequest;
1010
import org.junit.internal.runners.ErrorReportingRunner;
1111
import org.junit.runner.manipulation.Filter;
12-
import org.junit.runner.manipulation.InvalidOrderingException;
1312
import org.junit.runner.manipulation.Ordering;
1413
import org.junit.runners.model.InitializationError;
1514

@@ -197,19 +196,7 @@ public Request sortWith(Comparator<Description> comparator) {
197196
* @return a Request with ordered Tests
198197
* @since 4.13
199198
*/
200-
public Request orderWith(final Ordering ordering) {
201-
final Request delegate = this;
202-
return new Request() {
203-
@Override
204-
public Runner getRunner() {
205-
try {
206-
Runner runner = delegate.getRunner();
207-
ordering.apply(runner);
208-
return runner;
209-
} catch (InvalidOrderingException e) {
210-
return new ErrorReportingRunner(ordering.getClass(), e);
211-
}
212-
}
213-
};
199+
public Request orderWith(Ordering ordering) {
200+
return new OrderingRequest(this, ordering);
214201
}
215202
}

0 commit comments

Comments
 (0)