Skip to content

Commit e1172af

Browse files
committed
minor cleanup
1 parent b11b5aa commit e1172af

File tree

4 files changed

+20
-5
lines changed

4 files changed

+20
-5
lines changed

Diff for: build.xml

+3-1
Original file line numberDiff line numberDiff line change
@@ -207,12 +207,14 @@
207207
<run-local-tests />
208208
</target>
209209

210-
<target name="dist" depends="populate-dist">
210+
<target name="test-dist" depends="populate-dist">
211211
<run-dist-tests>
212212
<jvmarg value="-Dignore.this=ignored"/>
213213
</run-dist-tests>
214214
</target>
215215

216+
<target name="dist" depends="test-dist" />
217+
216218
<target name="profile" depends="populate-dist">
217219
<run-dist-tests>
218220
<jvmarg value="-agentlib:hprof=cpu=samples"/>

Diff for: src/main/java/org/junit/runner/notification/SynchronizedRunListener.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,6 @@ public boolean equals(Object other) {
106106

107107
@Override
108108
public String toString() {
109-
return fListener.toString();
109+
return fListener.toString() + " (with synchronization wrapper)";
110110
}
111111
}

Diff for: src/test/java/org/junit/runner/notification/ConcurrentRunNotifierTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ public void run() {
5959
fNotifier.removeListener(listener1);
6060
fNotifier.removeListener(listener2);
6161

62-
assertThat(listener1.fTestStarted.get(), is(4));
63-
assertThat(listener2.fTestStarted.get(), is(4));
62+
assertThat(listener1.fTestStarted.get(), is(numParallelTests));
63+
assertThat(listener2.fTestStarted.get(), is(numParallelTests));
6464
}
6565

6666
private static class ExaminedListener extends RunListener {

Diff for: src/test/java/org/junit/runner/notification/SynchronizedRunListenerTest.java

+14-1
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,11 @@ public NamedListener(String name) {
8181
fName = name;
8282
}
8383

84+
@Override
85+
public String toString() {
86+
return "NamedListener";
87+
}
88+
8489
@Override
8590
public int hashCode() {
8691
return fName.hashCode();
@@ -124,7 +129,15 @@ public void namedListenerCorrectlyImplementsEqualsAndHashCode() {
124129
assertEquals(listener1.hashCode(), listener2.hashCode());
125130
assertNotEquals(listener1.hashCode(), listener3.hashCode());
126131
}
127-
132+
133+
@Test
134+
public void toStringDelegates() {
135+
NamedListener listener = new NamedListener("blue");
136+
137+
assertEquals("NamedListener", listener.toString());
138+
assertEquals("NamedListener (with synchronization wrapper)", new SynchronizedRunListener(listener).toString());
139+
}
140+
128141
@Test
129142
public void equalsDelegates() {
130143
NamedListener listener1 = new NamedListener("blue");

0 commit comments

Comments
 (0)