Skip to content

Commit 2efacd3

Browse files
rybakmarcphilipp
authored andcommitted
Drop misleading messages in StandaloneTests
Test `execute()` in StandaloneTests asserts matching of lines between expected standard output and actual output lines. It also passes the same actual lines (but in a `String` form) as a message to method assertLinesMatch, which takes three arguments. Same situation for standard error. Drop this confusing argument from the two calls to assertLinesMatch and let class `AssertLinesMatch` construct the error message for us. (cherry picked from commit 7da21dd)
1 parent ca81494 commit 2efacd3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: platform-tooling-support-tests/src/test/java/platform/tooling/support/tests/StandaloneTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -354,8 +354,8 @@ void execute() throws IOException {
354354
var workspace = Request.WORKSPACE.resolve("standalone");
355355
var expectedOutLines = Files.readAllLines(workspace.resolve("expected-out.txt"));
356356
var expectedErrLines = Files.readAllLines(workspace.resolve("expected-err.txt"));
357-
assertLinesMatch(expectedOutLines, result.getOutputLines("out"), result.getOutput("out"));
358-
assertLinesMatch(expectedErrLines, result.getOutputLines("err"), result.getOutput("err"));
357+
assertLinesMatch(expectedOutLines, result.getOutputLines("out"));
358+
assertLinesMatch(expectedErrLines, result.getOutputLines("err"));
359359

360360
var jupiterVersion = Helper.version("junit-jupiter-engine");
361361
var vintageVersion = Helper.version("junit-vintage-engine");

0 commit comments

Comments
 (0)