Skip to content

Commit 0186eb8

Browse files
committed
Adjust kernel management with recent async updates
1 parent 3aa2498 commit 0186eb8

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

jupyter_server/services/kernels/kernelmanager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,13 +105,13 @@ def shutdown(self, now=False):
105105
self.restarter.stop()
106106

107107
if now or (self.client is None):
108-
self.manager.kill()
108+
yield self.manager.kill()
109109
else:
110110
yield self.client_connected
111111
yield self.client.shutdown_or_terminate()
112112

113113
self._close_client()
114-
self.manager.cleanup()
114+
yield self.manager.cleanup()
115115

116116
@gen.coroutine
117117
def interrupt(self):

jupyter_server/services/kernelspecs/handlers.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,7 @@ def get(self):
6363
model = {}
6464
model['default'] = km.default_kernel_name
6565
model['kernelspecs'] = specs = {}
66-
found_kernels = yield maybe_future(kf.find_kernels())
67-
for kernel_name, kernel_info in found_kernels:
66+
for kernel_name, kernel_info in kf.find_kernels():
6867
try:
6968
if is_kernelspec_model(kernel_info):
7069
d = kernel_info
@@ -85,10 +84,8 @@ class KernelSpecHandler(APIHandler):
8584
@gen.coroutine
8685
def get(self, kernel_name):
8786
kf = self.kernel_finder
88-
# TODO: Do we actually want all kernel type names to be case-insensitive?
8987
kernel_name = kernel_name.lower()
90-
found_specs = yield maybe_future(kf.find_kernels())
91-
for name, kernel_info in found_specs:
88+
for name, kernel_info in kf.find_kernels():
9289
if name == kernel_name:
9390
if is_kernelspec_model(kernel_info):
9491
model = kernel_info

0 commit comments

Comments
 (0)