doc

hadim · hadim · commit 3d185e16cc59 · 2020-07-07T08:07:54.000-04:00
diff --git a/jupyter_server/files/handlers.py b/jupyter_server/files/handlers.py
@@ -187,11 +187,6 @@ async def get(self, archive_path, include_body=False):
         )
 
         self.canceled = False
-
-        # The original extension is using `ioloop.PeriodicCallback` and `ioloop.IOLoop.current().run_in_executor`
-        # but it does not seem to work here (500 internal HTTP error).
-        # This trategy is nice when compressing very large directory. Any idea how to integrate that is welcome.
-
         self.flush_cb = ioloop.PeriodicCallback(
             self.flush, ARCHIVE_DOWNLOAD_FLUSH_DELAY
         )

Original file line number	Diff line number	Diff line change
`@@ -187,11 +187,6 @@ async def get(self, archive_path, include_body=False):`
`187`	`187`	`)`
`188`	`188`
`189`	`189`	`self.canceled = False`
`190`		`-`
`191`		- # The original extension is using `ioloop.PeriodicCallback` and `ioloop.IOLoop.current().run_in_executor`
`192`		`- # but it does not seem to work here (500 internal HTTP error).`
`193`		`- # This trategy is nice when compressing very large directory. Any idea how to integrate that is welcome.`
`194`		`-`
`195`	`190`	`self.flush_cb = ioloop.PeriodicCallback(`
`196`	`191`	`self.flush, ARCHIVE_DOWNLOAD_FLUSH_DELAY`
`197`	`192`	`)`