Skip to content

Make KernelSpecManager and KernelManager configurable #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shiti-saxena opened this issue Nov 1, 2017 · 2 comments · Fixed by #266
Closed

Make KernelSpecManager and KernelManager configurable #265

shiti-saxena opened this issue Nov 1, 2017 · 2 comments · Fixed by #266

Comments

@shiti-saxena
Copy link
Contributor

We want to make KernelSpecManager and kernel_manager_class configurable at run-time. This gives users flexibility to customize how Kernelspecs are fetched and how kernels are started.

@rolweber
Copy link
Contributor

rolweber commented Nov 2, 2017

Seems appropriate for websockets mode.

I wonder how this interacts with the notebook-http mode, where only a single kernel is started at the time the kernel gateway itself starts up. It makes sense to have a configurable KernelSpecManager there, yes. But replacing the kernel manager seems odd in that mode.

@rolweber rolweber changed the title Additional run-time configurations for Kernel Gateway Make KernelSpecManager and KernelManager configurable Nov 2, 2017
@shiti-saxena
Copy link
Contributor Author

shiti-saxena commented Nov 2, 2017

These changes simplify running Kernel Gateway through app orchestration framework such as Docker/Kubernetes.
The notebook-http mode also starts a kernel and if users want to customize how that kernel is started/ stopped they will be able to do so by configuring the KernelManager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants