Skip to content

Commit 80410bf

Browse files
ibdafnaibdafna
authored
Merge pull request #3233 from jasongrout/lint
Update linting
2 parents b57b898 + 6d3bcde commit 80410bf

File tree

100 files changed

+1532
-1553
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

100 files changed

+1532
-1553
lines changed

‎.github/workflows/lint.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,4 @@ jobs:
2626
run: |
2727
yarn install --frozen-lockfile
2828
yarn run integrity
29-
yarn run eslint:check
29+
yarn run lint:check

‎examples/web1/index.js

+11-11
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var WidgetManager = require('./manager').WidgetManager;
33

44
require('@jupyter-widgets/controls/css/widgets.css');
55

6-
document.addEventListener('DOMContentLoaded', function(event) {
6+
document.addEventListener('DOMContentLoaded', function (event) {
77
var manager = new WidgetManager(document.body);
88

99
/**
@@ -16,20 +16,20 @@ document.addEventListener('DOMContentLoaded', function(event) {
1616
.new_model({
1717
model_module: '@jupyter-widgets/controls',
1818
model_name: widgetType + 'Model',
19-
model_id: 'widget-1'
19+
model_id: 'widget-1',
2020
// Create a view for the model.
2121
})
22-
.then(function(model) {
22+
.then(function (model) {
2323
console.log(widgetType + ' model created');
2424

2525
model.set({
2626
description: description || '',
27-
value: value
27+
value: value,
2828
});
2929

3030
return manager.create_view(model);
3131
}, console.error.bind(console))
32-
.then(function(view) {
32+
.then(function (view) {
3333
console.log(widgetType + ' view created');
3434
manager.display_view(view);
3535
return view;
@@ -48,26 +48,26 @@ document.addEventListener('DOMContentLoaded', function(event) {
4848
model_id: 'widget-2',
4949
state: {
5050
source: null,
51-
target: null
52-
}
51+
target: null,
52+
},
5353
// Set the link model state.
5454
})
55-
.then(function(link) {
55+
.then(function (link) {
5656
console.log('link created');
5757

58-
return Promise.all([textArea, html]).then(function(models) {
58+
return Promise.all([textArea, html]).then(function (models) {
5959
console.log('setting link');
6060
var textArea = models[0];
6161
var html = models[1];
6262
link.set({
6363
source: [textArea.model, 'value'],
64-
target: [html.model, 'value']
64+
target: [html.model, 'value'],
6565
});
6666
link.save_changes();
6767
console.log('link set');
6868
});
6969
})
70-
.then(function() {
70+
.then(function () {
7171
var event = new Event('widgetsRendered');
7272
document.dispatchEvent(event);
7373
});

‎examples/web1/karma.config.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Karma configuration
22
// Generated on Mon Dec 07 2015 08:28:33 GMT-0800 (PST)
33

4-
module.exports = function(config) {
4+
module.exports = function (config) {
55
var cfg = {
66
// base path that will be used to resolve all patterns (eg. files, exclude)
77
basePath: '',
@@ -42,8 +42,8 @@ module.exports = function(config) {
4242
customLaunchers: {
4343
Chrome_travis_ci: {
4444
base: 'Chrome',
45-
flags: ['--no-sandbox']
46-
}
45+
flags: ['--no-sandbox'],
46+
},
4747
},
4848

4949
// Continuous Integration mode
@@ -52,7 +52,7 @@ module.exports = function(config) {
5252

5353
// Concurrency level
5454
// how many browser should be started simultanous
55-
concurrency: Infinity
55+
concurrency: Infinity,
5656
};
5757

5858
if (process.env.TRAVIS) {

‎examples/web1/manager.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,21 @@ class WidgetManager extends ManagerBase {
1010
}
1111

1212
loadClass(className, moduleName, moduleVersion) {
13-
return new Promise(function(resolve, reject) {
13+
return new Promise(function (resolve, reject) {
1414
if (moduleName === '@jupyter-widgets/controls') {
1515
resolve(controls);
1616
} else if (moduleName === '@jupyter-widgets/base') {
1717
resolve(base);
1818
} else {
19-
var fallback = function(err) {
19+
var fallback = function (err) {
2020
let failedId = err.requireModules && err.requireModules[0];
2121
if (failedId) {
2222
console.log(
2323
`Falling back to jsDelivr for ${moduleName}@${moduleVersion}`
2424
);
2525
window.require(
2626
[
27-
`https://cdn.jsdelivr.net/npm/${moduleName}@${moduleVersion}/dist/index.js`
27+
`https://cdn.jsdelivr.net/npm/${moduleName}@${moduleVersion}/dist/index.js`,
2828
],
2929
resolve,
3030
reject
@@ -35,7 +35,7 @@ class WidgetManager extends ManagerBase {
3535
};
3636
window.require([`${moduleName}.js`], resolve, fallback);
3737
}
38-
}).then(function(module) {
38+
}).then(function (module) {
3939
if (module[className]) {
4040
return module[className];
4141
} else {
@@ -48,7 +48,7 @@ class WidgetManager extends ManagerBase {
4848

4949
display_view(view) {
5050
var that = this;
51-
return Promise.resolve(view).then(view => {
51+
return Promise.resolve(view).then((view) => {
5252
LuminoWidget.attach(view.luminoWidget, that.el);
5353
return view;
5454
});

‎examples/web1/test/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const widgetsRendered = new Promise((resolve, reject) => {
1111
document.addEventListener('widgetsRendered', listener);
1212
});
1313

14-
describe('index.html', function() {
14+
describe('index.html', function () {
1515
this.timeout(10000);
1616

1717
beforeEach(() => {

‎examples/web1/webpack.config.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -7,21 +7,21 @@ module.exports = {
77
output: {
88
filename: 'index.built.js',
99
path: path.resolve(__dirname, 'built'),
10-
publicPath: 'built/'
10+
publicPath: 'built/',
1111
},
1212
module: {
1313
rules: [
1414
{ test: /\.css$/, use: ['style-loader', 'css-loader'] },
1515
// jquery-ui loads some images
16-
{ test: /\.(jpg|png|gif)$/, use: 'file-loader' }
17-
]
16+
{ test: /\.(jpg|png|gif)$/, use: 'file-loader' },
17+
],
1818
},
1919
plugins: [
2020
new webpack.DefinePlugin({
2121
// Needed for Blueprint. See https://github.com/palantir/blueprint/issues/4393
2222
'process.env': '{}',
2323
// Needed for various packages using cwd(), like the path polyfill
24-
process: { cwd: () => '/' }
25-
})
26-
]
24+
process: { cwd: () => '/' },
25+
}),
26+
],
2727
};

‎examples/web2/index.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ var WidgetManager = require('./manager').WidgetManager;
66
require('@jupyter-widgets/controls/css/widgets.css');
77
require('font-awesome/css/font-awesome.css');
88

9-
document.addEventListener('DOMContentLoaded', function(event) {
9+
document.addEventListener('DOMContentLoaded', function (event) {
1010
var code = require('./widget_code.py').default;
1111
var inputarea = document.getElementsByClassName('inputarea')[0];
1212
new CodeMirror(inputarea, {
@@ -15,20 +15,20 @@ document.addEventListener('DOMContentLoaded', function(event) {
1515
tabSize: 4,
1616
showCursorWhenSelecting: true,
1717
viewportMargin: Infinity,
18-
readOnly: true
18+
readOnly: true,
1919
});
2020

2121
var state = require('./widget_state.json');
2222
var widgetarea = document.getElementsByClassName('widgetarea')[0];
2323
var manager = new WidgetManager(widgetarea);
2424
manager
2525
.set_state(state)
26-
.then(models =>
26+
.then((models) =>
2727
manager.create_view(
2828
models.find(
29-
element => element.model_id == '8621699ecc804983a612f09b7dfe806b'
29+
(element) => element.model_id == '8621699ecc804983a612f09b7dfe806b'
3030
)
3131
)
3232
)
33-
.then(view => manager.display_view(view));
33+
.then((view) => manager.display_view(view));
3434
});

‎examples/web2/manager.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,21 @@ class WidgetManager extends ManagerBase {
1010
}
1111

1212
loadClass(className, moduleName, moduleVersion) {
13-
return new Promise(function(resolve, reject) {
13+
return new Promise(function (resolve, reject) {
1414
if (moduleName === '@jupyter-widgets/controls') {
1515
resolve(controls);
1616
} else if (moduleName === '@jupyter-widgets/base') {
1717
resolve(base);
1818
} else {
19-
var fallback = function(err) {
19+
var fallback = function (err) {
2020
let failedId = err.requireModules && err.requireModules[0];
2121
if (failedId) {
2222
console.log(
2323
`Falling back to jsDelivr for ${moduleName}@${moduleVersion}`
2424
);
2525
window.require(
2626
[
27-
`https://cdn.jsdelivr.net/npm/${moduleName}@${moduleVersion}/dist/index.js`
27+
`https://cdn.jsdelivr.net/npm/${moduleName}@${moduleVersion}/dist/index.js`,
2828
],
2929
resolve,
3030
reject
@@ -35,7 +35,7 @@ class WidgetManager extends ManagerBase {
3535
};
3636
window.require([`${moduleName}.js`], resolve, fallback);
3737
}
38-
}).then(function(module) {
38+
}).then(function (module) {
3939
if (module[className]) {
4040
return module[className];
4141
} else {
@@ -48,7 +48,7 @@ class WidgetManager extends ManagerBase {
4848

4949
display_view(view) {
5050
var that = this;
51-
return Promise.resolve(view).then(function(view) {
51+
return Promise.resolve(view).then(function (view) {
5252
LuminoWidget.attach(view.luminoWidget, that.el);
5353
return view;
5454
});

‎examples/web2/webpack.config.js

+18-18
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ module.exports = {
77
output: {
88
filename: 'index.built.js',
99
path: path.resolve(__dirname, 'built'),
10-
publicPath: 'built/'
10+
publicPath: 'built/',
1111
},
1212
module: {
1313
rules: [
@@ -22,29 +22,29 @@ module.exports = {
2222
loader: 'url-loader',
2323
options: {
2424
limit: 10000,
25-
mimetype: 'application/font-woff'
26-
}
27-
}
25+
mimetype: 'application/font-woff',
26+
},
27+
},
2828
},
2929
{
3030
test: /\.woff(\?v=\d+\.\d+\.\d+)?$/,
3131
use: {
3232
loader: 'url-loader',
3333
options: {
3434
limit: 10000,
35-
mimetype: 'application/font-woff'
36-
}
37-
}
35+
mimetype: 'application/font-woff',
36+
},
37+
},
3838
},
3939
{
4040
test: /\.ttf(\?v=\d+\.\d+\.\d+)?$/,
4141
use: {
4242
loader: 'url-loader',
4343
options: {
4444
limit: 10000,
45-
mimetype: 'application/octet-stream'
46-
}
47-
}
45+
mimetype: 'application/octet-stream',
46+
},
47+
},
4848
},
4949
{ test: /\.eot(\?v=\d+\.\d+\.\d+)?$/, use: 'file-loader' },
5050
{
@@ -53,18 +53,18 @@ module.exports = {
5353
loader: 'url-loader',
5454
options: {
5555
limit: 10000,
56-
mimetype: 'image/svg+xml'
57-
}
58-
}
59-
}
60-
]
56+
mimetype: 'image/svg+xml',
57+
},
58+
},
59+
},
60+
],
6161
},
6262
plugins: [
6363
new webpack.DefinePlugin({
6464
// Needed for Blueprint. See https://github.com/palantir/blueprint/issues/4393
6565
'process.env': '{}',
6666
// Needed for various packages using cwd(), like the path polyfill
67-
process: { cwd: () => '/' }
68-
})
69-
]
67+
process: { cwd: () => '/' },
68+
}),
69+
],
7070
};

‎examples/web3/src/index.ts

+5-9
Original file line numberDiff line numberDiff line change
@@ -7,25 +7,21 @@ import { WidgetManager } from './manager';
77
import {
88
KernelManager,
99
ServerConnection,
10-
KernelMessage
10+
KernelMessage,
1111
} from '@jupyterlab/services';
1212

1313
const BASEURL = prompt('Notebook BASEURL', 'http://localhost:8888');
1414
if (BASEURL === null) {
1515
alert('A base URL is needed to run the example!');
1616
throw new Error('A base URL is needed to run the example!');
1717
}
18-
const WSURL =
19-
'ws:' +
20-
BASEURL.split(':')
21-
.slice(1)
22-
.join(':');
18+
const WSURL = 'ws:' + BASEURL.split(':').slice(1).join(':');
2319

24-
document.addEventListener('DOMContentLoaded', async function(event) {
20+
document.addEventListener('DOMContentLoaded', async function (event) {
2521
// Connect to the notebook webserver.
2622
const connectionInfo = ServerConnection.makeSettings({
2723
baseUrl: BASEURL!,
28-
wsUrl: WSURL
24+
wsUrl: WSURL,
2925
});
3026
const kernelManager = new KernelManager({ serverSettings: connectionInfo });
3127
const kernel = await kernelManager.startNew();
@@ -41,7 +37,7 @@ document.addEventListener('DOMContentLoaded', async function(event) {
4137
tabSize: 4,
4238
showCursorWhenSelecting: true,
4339
viewportMargin: Infinity,
44-
readOnly: true
40+
readOnly: true,
4541
});
4642

4743
// Create the widget area and widget manager

‎examples/web3/src/manager.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export class WidgetManager extends HTMLManager {
3838
_get_comm_info(): Promise<any> {
3939
return this.kernel
4040
.requestCommInfo({ target_name: this.comm_target_name })
41-
.then(reply => (reply.content as any).comms);
41+
.then((reply) => (reply.content as any).comms);
4242
}
4343

4444
kernel: Kernel.IKernelConnection;

0 commit comments

Comments
 (0)