Skip to content

Commit 96f52ba

Browse files
jasongroutjasongrout
committed
Lint
1 parent 2b7331b commit 96f52ba

File tree

11 files changed

+171
-156
lines changed

11 files changed

+171
-156
lines changed

‎examples/web1/manager.js

+34-34
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,21 @@ var controls = require('@jupyter-widgets/controls');
44
var LuminoWidget = require('@lumino/widgets').Widget;
55

66
class WidgetManager extends ManagerBase {
7-
constructor(el) {
8-
super();
9-
this.el = el;
10-
}
7+
constructor(el) {
8+
super();
9+
this.el = el;
10+
}
1111

12-
loadClass(className, moduleName, moduleVersion) {
13-
return new Promise(function(resolve, reject) {
14-
if (moduleName === '@jupyter-widgets/controls') {
15-
resolve(controls);
16-
} else if (moduleName === '@jupyter-widgets/base') {
12+
loadClass(className, moduleName, moduleVersion) {
13+
return new Promise(function(resolve, reject) {
14+
if (moduleName === '@jupyter-widgets/controls') {
15+
resolve(controls);
16+
} else if (moduleName === '@jupyter-widgets/base') {
1717
resolve(base);
18-
} else {
19-
var fallback = function(err) {
20-
let failedId = err.requireModules && err.requireModules[0];
21-
if (failedId) {
18+
} else {
19+
var fallback = function(err) {
20+
let failedId = err.requireModules && err.requireModules[0];
21+
if (failedId) {
2222
console.log(
2323
`Falling back to unpkg.com for ${moduleName}@${moduleVersion}`
2424
);
@@ -29,38 +29,38 @@ class WidgetManager extends ManagerBase {
2929
resolve,
3030
reject
3131
);
32-
} else {
33-
throw err;
34-
}
35-
};
36-
window.require([`${moduleName}.js`], resolve, fallback);
37-
}
38-
}).then(function(module) {
39-
if (module[className]) {
40-
return module[className];
41-
} else {
32+
} else {
33+
throw err;
34+
}
35+
};
36+
window.require([`${moduleName}.js`], resolve, fallback);
37+
}
38+
}).then(function(module) {
39+
if (module[className]) {
40+
return module[className];
41+
} else {
4242
return Promise.reject(
4343
`Class ${className} not found in module ${moduleName}@${moduleVersion}`
4444
);
45-
}
46-
});
47-
}
45+
}
46+
});
47+
}
4848

4949
display_view(view) {
50-
var that = this;
50+
var that = this;
5151
return Promise.resolve(view).then(view => {
5252
LuminoWidget.attach(view.pWidget, that.el);
53-
return view;
54-
});
53+
return view;
54+
});
5555
}
5656

57-
_get_comm_info() {
58-
return Promise.resolve({});
57+
_get_comm_info() {
58+
return Promise.resolve({});
5959
}
6060

61-
_create_comm() {
62-
return Promise.reject('no comms available');
63-
}
61+
_create_comm() {
62+
return Promise.reject('no comms available');
63+
}
6464
}
6565

6666
exports.WidgetManager = WidgetManager;

‎examples/web1/webpack.config.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@ module.exports = {
44
mode: 'development',
55
entry: './index.js',
66
output: {
7-
filename: 'index.built.js',
8-
path: path.resolve(__dirname, 'built'),
9-
publicPath: 'built/'
7+
filename: 'index.built.js',
8+
path: path.resolve(__dirname, 'built'),
9+
publicPath: 'built/'
1010
},
1111
module: {
1212
rules: [
13-
{ test: /\.css$/, use: ['style-loader', 'css-loader']},
13+
{ test: /\.css$/, use: ['style-loader', 'css-loader'] },
1414
// jquery-ui loads some images
15-
{ test: /\.(jpg|png|gif)$/, use: 'file-loader' },
15+
{ test: /\.(jpg|png|gif)$/, use: 'file-loader' }
1616
]
17-
}
17+
}
1818
};

‎examples/web2/manager.js

+35-35
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,21 @@ var controls = require('@jupyter-widgets/controls');
44
var LuminoWidget = require('@lumino/widgets').Widget;
55

66
class WidgetManager extends ManagerBase {
7-
constructor(el) {
8-
super();
9-
this.el = el;
10-
}
7+
constructor(el) {
8+
super();
9+
this.el = el;
10+
}
1111

12-
loadClass(className, moduleName, moduleVersion) {
13-
return new Promise(function(resolve, reject) {
14-
if (moduleName === '@jupyter-widgets/controls') {
15-
resolve(controls);
16-
} else if (moduleName === '@jupyter-widgets/base') {
12+
loadClass(className, moduleName, moduleVersion) {
13+
return new Promise(function(resolve, reject) {
14+
if (moduleName === '@jupyter-widgets/controls') {
15+
resolve(controls);
16+
} else if (moduleName === '@jupyter-widgets/base') {
1717
resolve(base);
18-
} else {
19-
var fallback = function(err) {
20-
let failedId = err.requireModules && err.requireModules[0];
21-
if (failedId) {
18+
} else {
19+
var fallback = function(err) {
20+
let failedId = err.requireModules && err.requireModules[0];
21+
if (failedId) {
2222
console.log(
2323
`Falling back to unpkg.com for ${moduleName}@${moduleVersion}`
2424
);
@@ -29,38 +29,38 @@ class WidgetManager extends ManagerBase {
2929
resolve,
3030
reject
3131
);
32-
} else {
33-
throw err;
34-
}
35-
};
36-
window.require([`${moduleName}.js`], resolve, fallback);
37-
}
38-
}).then(function(module) {
39-
if (module[className]) {
40-
return module[className];
41-
} else {
32+
} else {
33+
throw err;
34+
}
35+
};
36+
window.require([`${moduleName}.js`], resolve, fallback);
37+
}
38+
}).then(function(module) {
39+
if (module[className]) {
40+
return module[className];
41+
} else {
4242
return Promise.reject(
4343
`Class ${className} not found in module ${moduleName}@${moduleVersion}`
4444
);
45-
}
46-
});
47-
}
45+
}
46+
});
47+
}
4848

4949
display_view(view) {
50-
var that = this;
51-
return Promise.resolve(view).then(function(view) {
50+
var that = this;
51+
return Promise.resolve(view).then(function(view) {
5252
LuminoWidget.attach(view.pWidget, that.el);
53-
return view;
54-
});
53+
return view;
54+
});
5555
}
5656

57-
_get_comm_info() {
58-
return Promise.resolve({});
57+
_get_comm_info() {
58+
return Promise.resolve({});
5959
}
6060

61-
_create_comm() {
62-
return Promise.reject('no comms available');
63-
}
61+
_create_comm() {
62+
return Promise.reject('no comms available');
63+
}
6464
}
6565

6666
exports.WidgetManager = WidgetManager;

‎examples/web2/webpack.config.js

+57-45
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,61 @@
11
var path = require('path');
22

33
module.exports = {
4-
mode: 'development',
5-
entry: './index.js',
6-
output: {
7-
filename: 'index.built.js',
8-
path: path.resolve(__dirname, 'built'),
9-
publicPath: 'built/'
10-
},
11-
module: {
12-
rules: [
13-
{ test: /\.css$/, use: ['style-loader', 'css-loader']},
14-
{ test: /\.py$/, loader: "raw-loader" },
15-
// jquery-ui loads some images
16-
{ test: /\.(jpg|png|gif)$/, use: 'file-loader' },
17-
// required to load font-awesome
18-
{ test: /\.woff2(\?v=\d+\.\d+\.\d+)?$/, use: {
19-
loader: 'url-loader',
20-
options: {
21-
limit: 10000,
22-
mimetype: 'application/font-woff'
23-
}
24-
}},
25-
{ test: /\.woff(\?v=\d+\.\d+\.\d+)?$/, use: {
26-
loader: 'url-loader',
27-
options: {
28-
limit: 10000,
29-
mimetype: 'application/font-woff'
30-
}
31-
}},
32-
{ test: /\.ttf(\?v=\d+\.\d+\.\d+)?$/, use: {
33-
loader: 'url-loader',
34-
options: {
35-
limit: 10000,
36-
mimetype: 'application/octet-stream'
37-
}
38-
}},
39-
{ test: /\.eot(\?v=\d+\.\d+\.\d+)?$/, use: 'file-loader' },
40-
{ test: /\.svg(\?v=\d+\.\d+\.\d+)?$/, use: {
41-
loader: 'url-loader',
42-
options: {
43-
limit: 10000,
44-
mimetype: 'image/svg+xml'
45-
}
46-
}}
47-
]
48-
},
4+
mode: 'development',
5+
entry: './index.js',
6+
output: {
7+
filename: 'index.built.js',
8+
path: path.resolve(__dirname, 'built'),
9+
publicPath: 'built/'
10+
},
11+
module: {
12+
rules: [
13+
{ test: /\.css$/, use: ['style-loader', 'css-loader'] },
14+
{ test: /\.py$/, loader: 'raw-loader' },
15+
// jquery-ui loads some images
16+
{ test: /\.(jpg|png|gif)$/, use: 'file-loader' },
17+
// required to load font-awesome
18+
{
19+
test: /\.woff2(\?v=\d+\.\d+\.\d+)?$/,
20+
use: {
21+
loader: 'url-loader',
22+
options: {
23+
limit: 10000,
24+
mimetype: 'application/font-woff'
25+
}
26+
}
27+
},
28+
{
29+
test: /\.woff(\?v=\d+\.\d+\.\d+)?$/,
30+
use: {
31+
loader: 'url-loader',
32+
options: {
33+
limit: 10000,
34+
mimetype: 'application/font-woff'
35+
}
36+
}
37+
},
38+
{
39+
test: /\.ttf(\?v=\d+\.\d+\.\d+)?$/,
40+
use: {
41+
loader: 'url-loader',
42+
options: {
43+
limit: 10000,
44+
mimetype: 'application/octet-stream'
45+
}
46+
}
47+
},
48+
{ test: /\.eot(\?v=\d+\.\d+\.\d+)?$/, use: 'file-loader' },
49+
{
50+
test: /\.svg(\?v=\d+\.\d+\.\d+)?$/,
51+
use: {
52+
loader: 'url-loader',
53+
options: {
54+
limit: 10000,
55+
mimetype: 'image/svg+xml'
56+
}
57+
}
58+
}
59+
]
60+
}
4961
};

‎examples/web3/src/index.ts

+23-24
Original file line numberDiff line numberDiff line change
@@ -23,50 +23,49 @@ const WSURL =
2323
.join(':');
2424

2525
document.addEventListener('DOMContentLoaded', async function(event) {
26-
// Connect to the notebook webserver.
26+
// Connect to the notebook webserver.
2727
const connectionInfo = ServerConnection.makeSettings({
2828
baseUrl: BASEURL!,
29-
wsUrl: WSURL
30-
});
29+
wsUrl: WSURL
30+
});
3131
const kernelManager = new KernelManager({ serverSettings: connectionInfo });
3232
const kernel = await kernelManager.startNew();
3333

34-
// Create a codemirror instance
34+
// Create a codemirror instance
3535
const code = require('../widget_code.json').join('\n');
3636
const inputarea = document.getElementsByClassName(
3737
'inputarea'
3838
)[0] as HTMLElement;
39-
CodeMirror(inputarea, {
40-
value: code,
41-
mode: 'python',
42-
tabSize: 4,
43-
showCursorWhenSelecting: true,
44-
viewportMargin: Infinity,
45-
readOnly: true
46-
});
39+
CodeMirror(inputarea, {
40+
value: code,
41+
mode: 'python',
42+
tabSize: 4,
43+
showCursorWhenSelecting: true,
44+
viewportMargin: Infinity,
45+
readOnly: true
46+
});
4747

48-
// Create the widget area and widget manager
48+
// Create the widget area and widget manager
4949
const widgetarea = document.getElementsByClassName(
5050
'widgetarea'
5151
)[0] as HTMLElement;
5252
const manager = new WidgetManager(kernel);
5353

54-
// Run backend code to create the widgets. You could also create the
55-
// widgets in the frontend, like the other widget examples demonstrate.
54+
// Run backend code to create the widgets. You could also create the
55+
// widgets in the frontend, like the other widget examples demonstrate.
5656
const execution = kernel.requestExecute({ code: code });
5757
execution.onIOPub = async (msg): Promise<void> => {
58-
// If we have a display message, display the widget.
59-
if (KernelMessage.isDisplayDataMsg(msg)) {
58+
// If we have a display message, display the widget.
59+
if (KernelMessage.isDisplayDataMsg(msg)) {
6060
const widgetData: any =
6161
msg.content.data['application/vnd.jupyter.widget-view+json'];
62-
if (widgetData !== undefined && widgetData.version_major === 2) {
62+
if (widgetData !== undefined && widgetData.version_major === 2) {
6363
const model = await manager.get_model(widgetData.model_id);
64-
if (model !== undefined) {
64+
if (model !== undefined) {
6565
const view = await manager.create_view(model);
6666
lmWidget.Widget.attach(view.pWidget, widgetarea);
67-
}
68-
}
69-
}
70-
};
67+
}
68+
}
69+
}
70+
};
7171
});
72-

0 commit comments

Comments
 (0)