Skip to content

Commit a30e7dd

Browse files
committed
Backport pull request #2654 from jasongrout/upgrades
Package upgrades
1 parent fdd7109 commit a30e7dd

38 files changed

+2778
-2399
lines changed

.travis.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ python:
1111
- 3.5
1212
- 3.6
1313
- 3.7
14+
- 3.8
1415
addons:
1516
apt_packages:
1617
- pandoc
@@ -25,6 +26,7 @@ before_install:
2526
- 'if [[ $GROUP == python ]] ; then bash ./scripts/travis_before_install_py.sh ; fi'
2627
- 'if [[ $GROUP == doc ]] ; then bash ./scripts/travis_before_install_py.sh ; fi'
2728
- 'if [[ $GROUP == spec ]] ; then bash ./scripts/travis_before_install_py.sh ; fi'
29+
- 'if [[ $GROUP == js ]] ; then nvm install 12 ; fi'
2830
install:
2931
- 'if [[ $GROUP == python ]] ; then bash ./scripts/travis_install_py.sh ; fi'
3032
- 'if [[ $GROUP == doc ]] ; then bash ./scripts/travis_install_py.sh ; fi'
@@ -42,6 +44,6 @@ matrix:
4244
- python: 3.6
4345
env: GROUP=doc
4446
- python: 3.6
45-
env: GROUP=js BROWSER=firefox TRAVIS_NODE_VERSION=6.11.0
47+
env: GROUP=js BROWSER=firefox
4648
after_success:
4749
- coveralls

examples/web1/manager.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var base = require('@jupyter-widgets/base');
22
var controls = require('@jupyter-widgets/controls');
3-
var PhosphorWidget = require('@phosphor/widgets').Widget;
3+
var PhosphorWidget = require('@lumino/widgets').Widget;
44

55
class WidgetManager extends base.ManagerBase {
66
constructor(el) {

examples/web1/package.json

+4-5
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,16 @@
2020
},
2121
"devDependencies": {
2222
"chai": "^4.0.0",
23-
"css-loader": "^3.0.0",
24-
"file-loader": "^4.0.0",
25-
"json-loader": "^0.5.7",
23+
"css-loader": "^3.4.0",
24+
"file-loader": "^5.0.2",
2625
"karma": "^4.1.0",
2726
"karma-chai": "^0.1.0",
2827
"karma-chrome-launcher": "^2.2.0",
2928
"karma-firefox-launcher": "^1.1.0",
3029
"karma-mocha": "^1.3.0",
3130
"karma-mocha-reporter": "^2.2.5",
3231
"mocha": "^6.1.4",
33-
"style-loader": "^0.23.1",
34-
"webpack": "^4.35.0"
32+
"style-loader": "^1.1.2",
33+
"webpack": "^4.41.5"
3534
}
3635
}

examples/web2/manager.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var base = require('@jupyter-widgets/base');
22
var controls = require('@jupyter-widgets/controls');
3-
var PhosphorWidget = require('@phosphor/widgets').Widget;
3+
var PhosphorWidget = require('@lumino/widgets').Widget;
44

55
class WidgetManager extends base.ManagerBase {
66
constructor(el) {

examples/web2/package.json

+6-7
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,11 @@
1919
"font-awesome": "^4.7.0"
2020
},
2121
"devDependencies": {
22-
"css-loader": "^3.0.0",
23-
"file-loader": "^4.0.0",
24-
"json-loader": "^0.5.7",
25-
"raw-loader": "^3.0.0",
26-
"style-loader": "^0.23.1",
27-
"url-loader": "^2.0.0",
28-
"webpack": "^4.35.0"
22+
"css-loader": "^3.4.0",
23+
"file-loader": "^5.0.2",
24+
"raw-loader": "^4.0.0",
25+
"style-loader": "^1.1.2",
26+
"url-loader": "^3.0.0",
27+
"webpack": "^4.41.5"
2928
}
3029
}

examples/web3/package.json

+9-10
Original file line numberDiff line numberDiff line change
@@ -18,28 +18,27 @@
1818
"@jupyter-widgets/base": "^2.0.2",
1919
"@jupyter-widgets/controls": "^1.5.3",
2020
"@jupyter-widgets/html-manager": "^0.18.4",
21-
"@jupyterlab/services": "^4.0.0",
22-
"@phosphor/widgets": "^1.3.0",
21+
"@jupyterlab/services": "^5.0.0-beta.1",
22+
"@lumino/widgets": "^1.3.0",
2323
"codemirror": "^5.48.0",
2424
"font-awesome": "^4.7.0",
2525
"http-server": "^0.11.1"
2626
},
2727
"devDependencies": {
2828
"@types/codemirror": "^0.0.74",
2929
"@types/requirejs": "^2.1.31",
30-
"css-loader": "^3.0.0",
31-
"file-loader": "^4.0.0",
30+
"css-loader": "^3.4.0",
31+
"file-loader": "^5.0.2",
3232
"fs-extra": "^8.0.1",
33-
"json-loader": "^0.5.7",
3433
"postcss": "^7.0.17",
3534
"postcss-cssnext": "^3.1.0",
3635
"postcss-import": "^12.0.1",
3736
"postcss-loader": "^3.0.0",
3837
"rimraf": "^2.6.1",
39-
"style-loader": "^0.23.1",
40-
"tslint": "^5.18.0",
41-
"typescript": "~3.5.2",
42-
"url-loader": "^2.0.0",
43-
"webpack": "^4.35.0"
38+
"style-loader": "^1.1.2",
39+
"tslint": "^5.20.1",
40+
"typescript": "~3.7.4",
41+
"url-loader": "^3.0.0",
42+
"webpack": "^4.41.5"
4443
}
4544
}

examples/web3/src/index.ts

+35-40
Original file line numberDiff line numberDiff line change
@@ -7,59 +7,54 @@ import {
77
} from './manager';
88

99
import {
10-
Kernel, ServerConnection, KernelMessage
10+
KernelManager, ServerConnection, KernelMessage
1111
} from '@jupyterlab/services';
1212

1313
let BASEURL = prompt('Notebook BASEURL', 'http://localhost:8888');
1414
let WSURL = 'ws:' + BASEURL.split(':').slice(1).join(':');
1515

16-
document.addEventListener('DOMContentLoaded', function(event) {
16+
document.addEventListener('DOMContentLoaded', async function(event) {
1717

1818
// Connect to the notebook webserver.
1919
let connectionInfo = ServerConnection.makeSettings({
2020
baseUrl: BASEURL,
2121
wsUrl: WSURL
2222
});
23-
Kernel.getSpecs(connectionInfo).then(kernelSpecs => {
24-
return Kernel.startNew({
25-
name: kernelSpecs.default,
26-
serverSettings: connectionInfo
27-
});
28-
}).then(kernel => {
29-
30-
// Create a codemirror instance
31-
let code = require('../widget_code.json').join('\n');
32-
let inputarea = document.getElementsByClassName('inputarea')[0] as HTMLElement;
33-
CodeMirror(inputarea, {
34-
value: code,
35-
mode: 'python',
36-
tabSize: 4,
37-
showCursorWhenSelecting: true,
38-
viewportMargin: Infinity,
39-
readOnly: true
40-
});
41-
42-
// Create the widget area and widget manager
43-
let widgetarea = document.getElementsByClassName('widgetarea')[0] as HTMLElement;
44-
let manager = new WidgetManager(kernel, widgetarea);
23+
let kernelManager = new KernelManager({serverSettings: connectionInfo});
24+
let kernel = await kernelManager.startNew();
25+
26+
// Create a codemirror instance
27+
let code = require('../widget_code.json').join('\n');
28+
let inputarea = document.getElementsByClassName('inputarea')[0] as HTMLElement;
29+
CodeMirror(inputarea, {
30+
value: code,
31+
mode: 'python',
32+
tabSize: 4,
33+
showCursorWhenSelecting: true,
34+
viewportMargin: Infinity,
35+
readOnly: true
36+
});
4537

46-
// Run backend code to create the widgets. You could also create the
47-
// widgets in the frontend, like the other widget examples demonstrate.
48-
let execution = kernel.requestExecute({ code: code });
49-
execution.onIOPub = (msg) => {
50-
// If we have a display message, display the widget.
51-
if (KernelMessage.isDisplayDataMsg(msg)) {
52-
let widgetData: any = msg.content.data['application/vnd.jupyter.widget-view+json'];
53-
if (widgetData !== undefined && widgetData.version_major === 2) {
54-
let model = manager.get_model(widgetData.model_id);
55-
if (model !== undefined) {
56-
model.then(model => {
57-
manager.display_model(msg, model);
58-
});
59-
}
38+
// Create the widget area and widget manager
39+
let widgetarea = document.getElementsByClassName('widgetarea')[0] as HTMLElement;
40+
let manager = new WidgetManager(kernel, widgetarea);
41+
42+
// Run backend code to create the widgets. You could also create the
43+
// widgets in the frontend, like the other widget examples demonstrate.
44+
let execution = kernel.requestExecute({ code: code });
45+
execution.onIOPub = (msg) => {
46+
// If we have a display message, display the widget.
47+
if (KernelMessage.isDisplayDataMsg(msg)) {
48+
let widgetData: any = msg.content.data['application/vnd.jupyter.widget-view+json'];
49+
if (widgetData !== undefined && widgetData.version_major === 2) {
50+
let model = manager.get_model(widgetData.model_id);
51+
if (model !== undefined) {
52+
model.then(model => {
53+
manager.display_model(msg, model);
54+
});
6055
}
6156
}
62-
};
63-
});
57+
}
58+
};
6459
});
6560

examples/web3/src/manager.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import * as base from '@jupyter-widgets/base';
2-
import * as pWidget from '@phosphor/widgets';
2+
import * as pWidget from '@lumino/widgets';
33

44
import {
55
Kernel
@@ -39,7 +39,7 @@ class WidgetManager extends HTMLManager {
3939
* Create a comm.
4040
*/
4141
async _create_comm(target_name: string, model_id: string, data?: any, metadata?: any): Promise<base.shims.services.Comm> {
42-
let comm = await this.kernel.connectToComm(target_name, model_id);
42+
let comm = this.kernel.createComm(target_name, model_id);
4343
if (data || metadata) {
4444
comm.open(data, metadata);
4545
}

examples/web4/package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@
1717
"font-awesome": "^4.7.0"
1818
},
1919
"devDependencies": {
20-
"css-loader": "^3.0.0",
21-
"file-loader": "^4.0.0",
22-
"style-loader": "^0.23.1",
23-
"url-loader": "^2.0.0",
24-
"webpack": "^4.35.0"
20+
"css-loader": "^3.4.0",
21+
"file-loader": "^5.0.2",
22+
"style-loader": "^1.1.2",
23+
"url-loader": "^3.0.0",
24+
"webpack": "^4.41.5"
2525
}
2626
}

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"updated": "lerna updated"
1717
},
1818
"devDependencies": {
19-
"@jupyterlab/buildutils": "^1.0.0-rc.0",
19+
"@jupyterlab/buildutils": "^2.0.0-beta.1",
2020
"lerna": "^3.2.1"
2121
}
2222
}

packages/base/package.json

+7-7
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@
3232
"test:unit:ie": "npm run test:unit:default -- --browsers=IE"
3333
},
3434
"dependencies": {
35-
"@jupyterlab/services": "^4.0.0",
36-
"@phosphor/coreutils": "^1.2.0",
37-
"@phosphor/messaging": "^1.2.1",
38-
"@phosphor/widgets": "^1.3.0",
35+
"@jupyterlab/services": "^5.0.0-beta.1",
36+
"@lumino/coreutils": "^1.2.0",
37+
"@lumino/messaging": "^1.2.1",
38+
"@lumino/widgets": "^1.3.0",
3939
"@types/backbone": "^1.4.1",
4040
"@types/lodash": "^4.14.134",
4141
"backbone": "1.2.3",
@@ -68,8 +68,8 @@
6868
"rimraf": "^2.6.1",
6969
"sinon": "^7.3.2",
7070
"sinon-chai": "^3.3.0",
71-
"tslint": "^5.18.0",
72-
"typescript": "~3.5.2",
73-
"webpack": "^4.35.0"
71+
"tslint": "^5.20.1",
72+
"typescript": "~3.7.4",
73+
"webpack": "^4.41.5"
7474
}
7575
}

packages/base/src/registry.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import {
55
Token
6-
} from '@phosphor/coreutils';
6+
} from '@lumino/coreutils';
77

88
import {
99
WidgetModel, WidgetView

packages/base/src/services-shim.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -90,15 +90,15 @@ namespace shims {
9090
*/
9191
export
9292
class CommManager {
93-
constructor(jsServicesKernel: Kernel.IKernel) {
93+
constructor(jsServicesKernel: Kernel.IKernelConnection) {
9494
this.init_kernel(jsServicesKernel);
9595
}
9696

9797
/**
9898
* Hookup kernel events.
9999
* @param {Kernel.IKernel} jsServicesKernel - @jupyterlab/services Kernel.IKernel instance
100100
*/
101-
init_kernel(jsServicesKernel: Kernel.IKernel) {
101+
init_kernel(jsServicesKernel: Kernel.IKernelConnection) {
102102
this.kernel = jsServicesKernel; // These aren't really the same.
103103
this.jsServicesKernel = jsServicesKernel;
104104
}
@@ -107,7 +107,7 @@ namespace shims {
107107
* Creates a new connected comm
108108
*/
109109
async new_comm(target_name: string, data: any, callbacks: any, metadata: any, comm_id: string, buffers?: ArrayBuffer[] | ArrayBufferView[]): Promise<Comm> {
110-
let c = await Promise.resolve(this.jsServicesKernel.connectToComm(target_name, comm_id));
110+
let c = this.jsServicesKernel.createComm(target_name, comm_id);
111111
let comm = new Comm(c);
112112
this.register_comm(comm);
113113
comm.open(data, callbacks, metadata, buffers);
@@ -160,8 +160,8 @@ namespace shims {
160160

161161
targets = Object.create(null);
162162
comms = Object.create(null);
163-
kernel: Kernel.IKernel = null;
164-
jsServicesKernel: Kernel.IKernel = null;
163+
kernel: Kernel.IKernelConnection = null;
164+
jsServicesKernel: Kernel.IKernelConnection = null;
165165
}
166166

167167
/**
@@ -289,7 +289,7 @@ namespace shims {
289289
}
290290

291291
jsServicesComm: Kernel.IComm = null;
292-
kernel: Kernel.IKernel = null;
292+
kernel: Kernel.IKernelConnection = null;
293293
}
294294
}
295295
}

packages/base/src/utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77

88
import {
99
UUID
10-
} from '@phosphor/coreutils';
10+
} from '@lumino/coreutils';
1111

1212
import _isEqual from 'lodash/isEqual';
1313
import isPlainObject from 'lodash/isPlainObject';

packages/base/src/widget.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ import {
1414

1515
import {
1616
Widget, Panel
17-
} from '@phosphor/widgets';
17+
} from '@lumino/widgets';
1818

1919
import {
2020
Message, MessageLoop
21-
} from '@phosphor/messaging';
21+
} from '@lumino/messaging';
2222

2323
import {
2424
IClassicComm, ICallbacks

0 commit comments

Comments
 (0)