Skip to content

[Classic notebook] Add event listener to window.resize for top-level Phosphor widgets #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SylvainCorlay opened this issue Jun 28, 2019 · 4 comments
Closed

[Classic notebook] Add event listener to window.resize for top-level Phosphor widgets #2467

SylvainCorlay opened this issue Jun 28, 2019 · 4 comments
Assignees
@ibdafna
Milestone
8.0

Comments

@SylvainCorlay
Copy link
Member

Jupyter Widget views are phosphor widgets.

When displayed in a classic notebook output area, they are not notified for window resize events.

We should probably update the widgetsnbextension to add these event listeners.
@SylvainCorlay
Copy link
Member Author

cc @jasongrout @vidartf

@SylvainCorlay SylvainCorlay mentioned this issue Jul 2, 2019
Closed
@jasongrout jasongrout added this to the 8.0 milestone Jan 28, 2020
@jasongrout
Copy link
Member

Let's make sure this is happening.

@jasongrout jasongrout mentioned this issue Feb 17, 2021
Merged
@jasongrout
Copy link
Member

@ibdafna is working on this at #3124

@jasongrout
Copy link
Member

Fixed in #3124.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibdafna ibdafna

Labels
None yet
Projects
None yet
Milestone
8.0
Development

No branches or pull requests
3 participants
@jasongrout @SylvainCorlay @ibdafna