Add ability for Kernel Gateway to ignore SIGHUP signal #304
Conversation
There was a problem hiding this comment.
Interesting. Yeah, I can run JKG (well, Enterprise Gateway) forever, logging out, etc., but I'm primarily running on python 2. Thank you for this contribution.
My one suggestion is that we make this unconditional and remove the configuration hooks. JKG and EG are essentially services and should ignore SIGHUP (IMHO). Do you see an issue with that or were you not wanting to disrupt current behaviors?
My other (more selfish) reason is that we're going to introduce "session persistence" to Enterprise Gateway and would like to avoid overuse of that term in the options.
If you feel strongly about making this optional, then perhaps we could change the name to something like KG_IGNORE_HANGUP and make it default to True.
We'll want something similar in Enterprise Gateway since this is one of the methods we don't inherit.
|
Thanks for the reply Kevin. I see no issue with making it a default behavior, I was just trying to preserve default behavior and be non intrusive to current users. If you would like I can remove the config hooks. |
|
Awesome - yeah, let's just make it unconditional. I'll wait until tomorrow to merge for others to comment. Would you mind applying this to the Enterprise Gateway project? You'll find it familiar. 😄 |
|
All done Kevin! Thank you |
We noticed that when having kernel gateway run for extended periods of time the process would terminate when the user would logoff or if we killed the terminal that started the Kernel Gateway. We found out that python 3.x will not ignore the SIGHUP signal even when ran with nohup, this lead us to this solution.