Skip to content

Fix download handler to not use deprecated maybe_future call #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

kevin-bates
Copy link
Member

This is a follow-on PR to #322. The original test failures masked this issue.

@kevin-bates kevin-bates requested a review from lresende August 5, 2019 14:09
Copy link
Member

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lresende lresende merged commit e2f75d6 into jupyter-server:master Aug 5, 2019
@kevin-bates kevin-bates deleted the fix-download-handler branch September 19, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants