Skip to content

Commit 44c7f12

Browse files
author
Steven Silvester
authored
clean up link checking (#6130)
1 parent eb6c69d commit 44c7f12

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

.github/workflows/check-release.yml

+9-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ permissions:
1212
jobs:
1313
check_release:
1414
runs-on: ubuntu-latest
15+
strategy:
16+
matrix:
17+
group: [check_release, link_check]
1518
steps:
1619
- name: Checkout
1720
uses: actions/checkout@v2
@@ -37,10 +40,11 @@ jobs:
3740
${{ runner.os }}-pip-
3841
${{ runner.os }}-pip-
3942
- name: Cache checked links
43+
if: ${{ matrix.group == 'link_check' }}
4044
uses: actions/cache@v2
4145
with:
4246
path: ~/.cache/pytest-link-check
43-
key: ${{ runner.os }}-linkcheck-${{ hashFiles('**/.md') }}-md-links
47+
key: ${{ runner.os }}-linkcheck-${{ hashFiles('**/*.md', '**/*.rst') }}-md-links
4448
restore-keys: |
4549
${{ runner.os }}-linkcheck-
4650
- name: Upgrade packaging dependencies
@@ -50,8 +54,12 @@ jobs:
5054
run: |
5155
pip install -e .
5256
- name: Check Release
57+
if: ${{ matrix.group == 'check_release' }}
5358
env:
5459
TWINE_PASSWORD: ${{ secrets.TEST_PYPI_TOKEN }}
5560
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v1
5661
with:
5762
token: ${{ secrets.GITHUB_TOKEN }}
63+
- name: Check Links
64+
if: ${{ matrix.group == 'link_check' }}
65+
uses: jupyter-server/jupyter_releaser/.github/actions/check-links@v1

notebook/tests/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# IPython Notebook JavaScript Tests
22

33
This directory includes regression tests for the web notebook. These tests
4-
depend on [CasperJS](http://casperjs.org/), which in turn requires a recent
4+
depend on [CasperJS](https://github.com/casperjs/casperjs/), which in turn requires a recent
55
version of [PhantomJS](http://phantomjs.org/).
66

77
The JavaScript tests are organized into subdirectories that match those in

pyproject.toml

+3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ build-backend = "setuptools.build_meta"
66
ignore = ["docs-translations/**", ".*", "*.yml", "*.less", "git-hooks/**", "MANIFEST.in", "RELEASE.md", "jupyter.svg", "notebook/static/**", "notebook/i18n/**/*.json", "docs/source/*.*"]
77
ignore-bad-ideas = ["notebook/i18n/**/*.mo"]
88

9+
[tool.jupyter-releaser]
10+
skip = ["check-links"]
11+
912
[tool.jupyter-releaser.hooks]
1013
after-bump-version = "python setup.py jsversion"
1114
before-build-python = ["pip install babel", "npm install -g po2json"]

0 commit comments

Comments
 (0)