Skip to content

Commit bba82ca

Browse files
authored
Merge pull request #4412 from kevin-bates/async-startup
Enable restart_kernel for async usage
2 parents 46ee18b + 2c526fb commit bba82ca

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

notebook/services/kernels/kernelmanager.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -302,10 +302,11 @@ def shutdown_kernel(self, kernel_id, now=False):
302302

303303
return super(MappingKernelManager, self).shutdown_kernel(kernel_id, now=now)
304304

305+
@gen.coroutine
305306
def restart_kernel(self, kernel_id):
306307
"""Restart a kernel by kernel_id"""
307308
self._check_kernel_id(kernel_id)
308-
super(MappingKernelManager, self).restart_kernel(kernel_id)
309+
yield gen.maybe_future(super(MappingKernelManager, self).restart_kernel(kernel_id))
309310
kernel = self.get_kernel(kernel_id)
310311
# return a Future that will resolve when the kernel has successfully restarted
311312
channel = kernel.connect_shell()
@@ -341,7 +342,7 @@ def on_restart_failed():
341342
channel.on_recv(on_reply)
342343
loop = IOLoop.current()
343344
timeout = loop.add_timeout(loop.time() + self.kernel_info_timeout, on_timeout)
344-
return future
345+
raise gen.Return(future)
345346

346347
def notify_connect(self, kernel_id):
347348
"""Notice a new connection to a kernel"""

0 commit comments

Comments
 (0)