Skip to content

JS services test failure on Python 2.7 #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
takluyver opened this issue Dec 13, 2017 · 6 comments
Closed

JS services test failure on Python 2.7 #3127

takluyver opened this issue Dec 13, 2017 · 6 comments

Comments

@takluyver
Copy link
Member

Tests on Python 2.7 on Travis are failing like this:

FAIL one kernel running
#    type: assertEquals
#    file: /home/travis/build/jupyter/notebook/notebook/tests/services/kernel.js
#    subject: 2
#    expected: 1
FAIL one session running
#    type: assertEquals
#    file: /home/travis/build/jupyter/notebook/notebook/tests/services/session.js
#    subject: 4
#    expected: 1

@blink1073 was starting to investigate on #3120, but we haven't worked it out yet.

@blink1073
Copy link
Contributor

Is Python 2.7 dead yet? Oh what a happy day that would be....

@takluyver
Copy link
Member Author

I was thinking of aiming for notebook 6.0 and requiring Py 3 next year. But I think we'll need to figure this out one way or the other.

@blink1073
Copy link
Contributor

Agreed on both

@takluyver
Copy link
Member Author

It looks like for some reason it's starting a python3 kernel as well as the python2 one. :-/

@takluyver
Copy link
Member Author

I think I know where it's coming from. Investigating using #3128.

@takluyver
Copy link
Member Author

It wasn't where I was thinking - it turns out it was actually a problem with ipykernel: ipython/ipykernel#288 . I've made a workaround in #3128.

@minrk minrk added this to the Reference milestone Sep 13, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants