Skip to content

Stub toolbar visible at top of text files #6784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JasonWeill opened this issue Mar 22, 2023 · 2 comments
Closed

Stub toolbar visible at top of text files #6784

JasonWeill opened this issue Mar 22, 2023 · 2 comments
Labels
bug status:Needs Triage Applied to issues that need triage
Milestone

Comments

@JasonWeill
Copy link
Collaborator

There is a weird remnant of a minimized toolbar at the top of text files in notebook. Looks like we are pulling this over from lab without any modification to make it look right. Another difficult thing is that the line number column has the same background as the rest of the page, making it look odd.

This was found by @ellisonbg during a bug bash.

image

@JasonWeill JasonWeill added the bug label Mar 22, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Mar 22, 2023
@jtpio
Copy link
Member

jtpio commented Mar 22, 2023

Thanks for reporting.

I believe this comes from the default toolbar of the MainAreaWidget being empty. And is likely similar in JupyterLab as well. This was briefly discussed at a recent Notebook weekly call (cc @afshin).

Probably there should be some styling to hide it if is empty (although some extensions might add toolbar buttons to it).

@jtpio jtpio added this to the 7.0 milestone Mar 22, 2023
@jtpio
Copy link
Member

jtpio commented Mar 28, 2023

Closing as fixed by #6791

@jtpio jtpio closed this as completed Mar 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug status:Needs Triage Applied to issues that need triage
Projects
None yet
Development

No branches or pull requests

2 participants