Skip to content

Clear search #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mlucool opened this issue Aug 9, 2021 · 5 comments
Closed

Clear search #43

mlucool opened this issue Aug 9, 2021 · 5 comments

Comments

@mlucool
Copy link
Contributor

mlucool commented Aug 9, 2021

After pressing / there is no way to clear a matched search on a cell (unless of course you search for something not there). Can we clear search on entering nothing?

search

@ianhi
Copy link
Collaborator

ianhi commented Aug 10, 2021

This is actually the same as normal vim bevhior (at least in my terminal installation). The way to clear the search is with :noh.

It might be kind of nice to have something like https://github.com/junegunn/vim-slash but that probably belongs as as separate plugin that works with codemirror itself.

@mlucool
Copy link
Contributor Author

mlucool commented Aug 11, 2021

Yeah - turns out it was a mapping that maps / to clear also. Thoughts on doing something similar here (opt-in)?

@ianhi
Copy link
Collaborator

ianhi commented Aug 23, 2021

It feels like this ought to already be possible with https://github.com/ianhi/jupyterlab-vimrc#jupyterlab-vimrc although it may require some actual coding as in https://discuss.codemirror.net/t/possible-vim-leader-key-work-around/3006/4 as I'm not sure how well ex mappings work for the codemirror vim implementation

@peytondmurray
Copy link
Contributor

I think this issue can be closed now - somehow I forgot to target this issue in the related PR. Sorry!

@krassowski
Copy link
Collaborator

Closing as fixed by #74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants