Skip to content

Commit 912fdac

Browse files
committed
Upgrade to vega-embed 3.0.0rc2
1 parent 54363b6 commit 912fdac

File tree

4 files changed

+11
-21
lines changed

4 files changed

+11
-21
lines changed

packages/vega3-extension/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"@jupyterlab/rendermime-interfaces": "^0.4.0",
2020
"@phosphor/coreutils": "^1.2.0",
2121
"@phosphor/widgets": "^1.3.0",
22-
"vega-embed": "^3.0.0-beta.20"
22+
"vega-embed": "^3.0.0-rc2"
2323
},
2424
"devDependencies": {
2525
"rimraf": "^2.5.2",

packages/vega3-extension/src/index.ts

+4-6
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,7 @@ import {
1515
IRenderMime
1616
} from '@jupyterlab/rendermime-interfaces';
1717

18-
/**
19-
* Import vega-embed in this manner due to how it is exported.
20-
*/
21-
import embed = require('vega-embed');
18+
import vegaEmbed, {Mode} from 'vega-embed';
2219

2320

2421
import '../style/index.css';
@@ -78,16 +75,17 @@ class RenderedVega3 extends Widget implements IRenderMime.IRenderer {
7875
*/
7976
renderModel(model: IRenderMime.IMimeModel): Promise<void> {
8077
const data = model.data[this._mimeType] as JSONObject;
78+
const mode: Mode = this._mimeType === VEGA_MIME_TYPE ? 'vega' : 'vega-lite';
8179
const options = {
82-
mode: this._mimeType === VEGA_MIME_TYPE ? 'vega' : 'vega-lite',
80+
mode,
8381
actions: true,
8482
config: this._mimeType === VEGA_MIME_TYPE
8583
? {}
8684
: {
8785
cell: { width: 400, height: 400 / 1.5 }
8886
}
8987
};
90-
return embed(this.node, data, options).then(result => {
88+
return vegaEmbed(this.node, data, options).then((result: Object) => {
9189
console.log(result);
9290
});
9391
}

packages/vega3-extension/src/vega-embed.d.ts

-11
This file was deleted.
+6-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"compilerOptions": {
33
"declaration": true,
4-
"noImplicitAny": true,
4+
"noImplicitAny": false,
55
"noEmitOnError": true,
66
"noUnusedLocals": true,
77
"module": "commonjs",
@@ -11,5 +11,8 @@
1111
"lib": ["ES5", "ES2015.Promise", "DOM", "ES2015.Collection"],
1212
"types": []
1313
},
14-
"include": ["src/*"]
15-
}
14+
"include": [
15+
"src/*",
16+
"../../node_modules/vega-embed/typings/vega.d.ts"
17+
]
18+
}

0 commit comments

Comments
 (0)