Ignore pageconfig file if JSON is zero-length (#444)

holzman · web-flow · commit 2cc9672e7519 · 2024-04-08T09:25:39.000+01:00
* Ignore pageconfig file if JSON is invalid

* Check for optional logger before using it

* Ignore pageconfig only if it is zero length
diff --git a/jupyterlab_server/config.py b/jupyterlab_server/config.py
@@ -126,7 +126,7 @@ def get_page_config(
             pjoin(app_settings_dir, "page_config.json"),
         ]
         for path in config_paths:
-            if osp.exists(path):
+            if osp.exists(path) and osp.getsize(path):
                 data = load_config(path)
                 # Convert lists to dicts
                 for key in [disabled_key, "deferredExtensions"]:

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ def get_page_config(`
`126`	`126`	`pjoin(app_settings_dir, "page_config.json"),`
`127`	`127`	`]`
`128`	`128`	`for path in config_paths:`
`129`		`- if osp.exists(path):`
	`129`	`+ if osp.exists(path) and osp.getsize(path):`
`130`	`130`	`data = load_config(path)`
`131`	`131`	`# Convert lists to dicts`
`132`	`132`	`for key in [disabled_key, "deferredExtensions"]:`